Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/webdatabase

BUG=707641
Review-Url: https://codereview.chromium.org/2813433002
Cr-Commit-Position: refs/heads/master@{#463576}
Committed: https://chromium.googlesource.com/chromium/src/+/226bee734ae45ec8634e1b1d9448cdce97d32290

[Hwanseung Lee, 2017-04-09 08:50:22]

Description was changed from

==========
Replace ASSiRT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/webdatabase

BUG=707641
==========

to

==========
Replace ASSiRT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/webdatabase

BUG=707641
==========

[Hwanseung Lee, 2017-04-09 08:50:22]

hs1217.lee@samsung.com changed reviewers:
+ haraken@chromium.org, michaeln@chromium.org, tkent@chromium.org

[Hwanseung Lee, 2017-04-09 08:50:28]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-09 08:50:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-09 08:50:43]

Description was changed from

==========
Replace ASSiRT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/webdatabase

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/webdatabase

BUG=707641
==========

[commit-bot: I haz the power, 2017-04-09 11:01:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 11:01:46]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-09 11:09:37]

PTAL, thank you.

[haraken, 2017-04-09 13:01:44]

LGTM

[Hwanseung Lee, 2017-04-09 22:31:36]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-04-09 22:31:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-09 22:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-09 22:38:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2017-04-09 23:09:42]

> Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

This CL looks to handle only ASSERT_NOT_REACHED.  There are many ASSERTs in
modules/webdatabase.

[Hwanseung Lee, 2017-04-10 15:37:31]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:37:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:47:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:47:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaeln, 2017-04-10 22:59:01]

https://codereview.chromium.org/2813433002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
(right):

https://codereview.chromium.org/2813433002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp:251:
DHCECK(!result_set_->IsValid());
lgtm % typo here

[Hwanseung Lee, 2017-04-10 23:08:08]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 23:08:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 23:24:04]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2017-04-11 02:32:48]

Patchset #3 (id:40001) has been deleted

[Hwanseung Lee, 2017-04-11 02:32:55]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 02:33:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 03:04:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 03:04:58]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Hwanseung Lee, 2017-04-11 03:42:30]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 03:42:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 04:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 04:17:20]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Hwanseung Lee, 2017-04-11 04:18:59]

Patchset #3 (id:60001) has been deleted

[Hwanseung Lee, 2017-04-11 05:56:25]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 05:56:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 06:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 06:23:21]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Hwanseung Lee, 2017-04-11 06:27:01]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 06:27:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 08:21:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 08:21:33]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-04-11 08:26:09]

https://codereview.chromium.org/2813433002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
(right):

https://codereview.chromium.org/2813433002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp:251:
DHCECK(!result_set_->IsValid());
On 2017/04/10 22:59:00, michaeln wrote:
> lgtm % typo here

Done.

[Hwanseung Lee, 2017-04-11 08:26:18]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-04-11 08:26:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, michaeln@chromium.org
Link to the patchset: https://codereview.chromium.org/2813433002/#ps120001
(title: "Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in
modules/webdatabase")

[Hwanseung Lee, 2017-04-11 08:26:33]

The CQ bit was unchecked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-04-11 08:27:42]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-04-11 08:28:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 08:39:52]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491899262549090,
"parent_rev": "e14aacd2baf5cf9c4a5e457384e0b0f73c0163c4", "commit_rev":
"226bee734ae45ec8634e1b1d9448cdce97d32290"}

[commit-bot: I haz the power, 2017-04-11 08:40:52]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/webdatabase

BUG=707641
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/webdatabase

BUG=707641

Review-Url: https://codereview.chromium.org/2813433002
Cr-Commit-Position: refs/heads/master@{#463576}
Committed:
https://chromium.googlesource.com/chromium/src/+/226bee734ae45ec8634e1b1d9448...
==========

[commit-bot: I haz the power, 2017-04-11 08:40:53]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/226bee734ae45ec8634e1b1d9448...