Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
index 0f533690bc99d235648cf34314f3e6ed23a86852..d7992392de048ecba7decdc9fc71ffa552873921 100644
--- a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp
@@ -121,7 +121,7 @@ void SQLiteDatabase::SetMaximumSize(int64_t size) {
int current_page_size = PageSize();
- ASSERT(current_page_size || !db_);
+ DCHECK(current_page_size || !db_);
int64_t new_max_page_count = current_page_size ? size / current_page_size : 0;
MutexLocker locker(authorizer_lock_);
@@ -261,7 +261,7 @@ int SQLiteDatabase::AuthorizerFunction(void* user_data,
const char* /*databaseName*/,
const char* /*trigger_or_view*/) {
DatabaseAuthorizer* auth = static_cast<DatabaseAuthorizer*>(user_data);
- ASSERT(auth);
+ DCHECK(auth);
switch (action_code) {
case SQLITE_CREATE_INDEX:
@@ -329,7 +329,7 @@ int SQLiteDatabase::AuthorizerFunction(void* user_data,
return auth->AllowFunction(parameter2);
#endif
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return kSQLAuthDeny;
}
}

Powered by Google App Engine
This is Rietveld 408576698