third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp - Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/ChangeVersionWrapper.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/Database.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp b/third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

index 29095a0d38c5147ac96807d77a9aed0396b15a92..c7516a1797b98cd5238ae0c48475eb5aeb95709a 100644

--- a/third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/DOMWindowWebDatabase.cpp

@@ -57,7 +57,7 @@ Database* DOMWindowWebDatabase::openDatabase(

database = db_manager.OpenDatabase(window.document(), name, version,

display_name, estimated_size,

creation_callback, error, error_message);

- ASSERT(database || error != DatabaseError::kNone);

+ DCHECK(database || error != DatabaseError::kNone);

if (error != DatabaseError::kNone)

DatabaseManager::ThrowExceptionForDatabaseError(error, error_message,

exception_state);