Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp b/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
index f3383b6baf6b0b16fcacec864ba1ca204e8705df..5384d1a53c454e24cb79273c4a10593a026be687 100644
--- a/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
@@ -118,7 +118,7 @@ void DatabaseTracker::RemoveOpenDatabase(Database* database) {
{
MutexLocker open_database_map_lock(open_database_map_guard_);
String origin_string = database->GetSecurityOrigin()->ToRawString();
- ASSERT(open_database_map_);
+ DCHECK(open_database_map_);
DatabaseNameMap* name_map = open_database_map_->at(origin_string);
if (!name_map)
return;
@@ -146,7 +146,7 @@ void DatabaseTracker::RemoveOpenDatabase(Database* database) {
}
void DatabaseTracker::PrepareToOpenDatabase(Database* database) {
- ASSERT(
+ DCHECK(
database->GetDatabaseContext()->GetExecutionContext()->IsContextThread());
if (Platform::Current()->DatabaseObserver()) {
Platform::Current()->DatabaseObserver()->DatabaseOpened(
@@ -205,7 +205,7 @@ void DatabaseTracker::ForEachOpenDatabaseInPage(
for (auto& name_database_set : *origin_map.value) {
for (Database* database : *name_database_set.value) {
ExecutionContext* context = database->GetExecutionContext();
- ASSERT(context->IsDocument());
+ DCHECK(context->IsDocument());
if (ToDocument(context)->GetFrame()->GetPage() == page)
(*callback)(database);
}

Powered by Google App Engine
This is Rietveld 408576698