third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h - Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/sqlite/SQLValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h

diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h b/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h

index 393bbdf95e4dc6e0642fa4f1865c67cae64b2389..da0337cc38445cf5850a717583e23f7920ad753b 100644

--- a/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h

+++ b/third_party/WebKit/Source/modules/webdatabase/SQLTransactionStateMachine.h

@@ -75,19 +75,19 @@ SQLTransactionStateMachine<T>::SQLTransactionStateMachine()

template <typename T>

void SQLTransactionStateMachine<T>::SetStateToRequestedState() {

- ASSERT(next_state_ == SQLTransactionState::kIdle);

- ASSERT(requested_state_ != SQLTransactionState::kIdle);

+ DCHECK_EQ(next_state_, SQLTransactionState::kIdle);

+ DCHECK_NE(requested_state_, SQLTransactionState::kIdle);

next_state_ = requested_state_;

requested_state_ = SQLTransactionState::kIdle;

}

template <typename T>

void SQLTransactionStateMachine<T>::RunStateMachine() {

- ASSERT(SQLTransactionState::kEnd < SQLTransactionState::kIdle);

+ DCHECK_LT(SQLTransactionState::kEnd, SQLTransactionState::kIdle);

while (next_state_ > SQLTransactionState::kIdle) {

- ASSERT(next_state_ < SQLTransactionState::kNumberOfStates);

+ DCHECK_LT(next_state_, SQLTransactionState::kNumberOfStates);

StateFunction state_function = StateFunctionFor(next_state_);

- ASSERT(state_function);

+ DCHECK(state_function);

#if DCHECK_IS_ON()

state_audit_trail_[next_state_audit_entry_] = next_state_;