Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp b/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
index c56e288bc9466f021856fc00b3612ce79c4c904e..1d1ba20aba45ef5fa466af88006bc77f134f2a4b 100644
--- a/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
@@ -38,7 +38,7 @@ namespace blink {
static String GetDatabaseIdentifier(SQLTransactionBackend* transaction) {
Database* database = transaction->GetDatabase();
- ASSERT(database);
+ DCHECK(database);
return database->StringIdentifier();
}
@@ -70,7 +70,7 @@ void SQLTransactionCoordinator::ProcessPendingTransactions(
void SQLTransactionCoordinator::AcquireLock(
SQLTransactionBackend* transaction) {
- ASSERT(!is_shutting_down_);
+ DCHECK(!is_shutting_down_);
String db_identifier = GetDatabaseIdentifier(transaction);
@@ -103,10 +103,10 @@ void SQLTransactionCoordinator::ReleaseLock(
CoordinationInfo& info = coordination_info_iterator->value;
if (transaction->IsReadOnly()) {
- ASSERT(info.active_read_transactions.Contains(transaction));
+ DCHECK(info.active_read_transactions.Contains(transaction));
info.active_read_transactions.erase(transaction);
} else {
- ASSERT(info.active_write_transaction == transaction);
+ DCHECK_EQ(info.active_write_transaction, transaction);
info.active_write_transaction = nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698