Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp b/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
index 180618a5bfce61376902477f05b7feb8ec54735f..8b317840c2fcd1cbfef652397a3bf2764a8e4eb0 100644
--- a/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp
@@ -124,7 +124,7 @@ SQLResultSet* SQLStatementBackend::SqlResultSet() const {
}
bool SQLStatementBackend::Execute(Database* db) {
- ASSERT(!result_set_->IsValid());
+ DCHECK(!result_set_->IsValid());
// If we're re-running this statement after a quota violation, we need to
// clear that error now
@@ -247,7 +247,8 @@ bool SQLStatementBackend::Execute(Database* db) {
}
void SQLStatementBackend::SetVersionMismatchedError(Database* database) {
- ASSERT(!error_ && !result_set_->IsValid());
+ DCHECK(!error_);
+ DCHECK(!result_set_->IsValid());
database->ReportExecuteStatementResult(7, SQLError::kVersionErr, 0);
error_ = SQLErrorData::Create(
SQLError::kVersionErr,
@@ -255,7 +256,8 @@ void SQLStatementBackend::SetVersionMismatchedError(Database* database) {
}
void SQLStatementBackend::SetFailureDueToQuota(Database* database) {
- ASSERT(!error_ && !result_set_->IsValid());
+ DCHECK(!error_);
+ DCHECK(!result_set_->IsValid());
database->ReportExecuteStatementResult(8, SQLError::kQuotaErr, 0);
error_ = SQLErrorData::Create(SQLError::kQuotaErr,
"there was not enough remaining storage "

Powered by Google App Engine
This is Rietveld 408576698