Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase

third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp

 /*
  * Copyright (C) 2007, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 106 matching lines @@
 
 SQLErrorData* SQLStatementBackend::SqlError() const {
   return error_.get();
 }
 
 SQLResultSet* SQLStatementBackend::SqlResultSet() const {
   return result_set_->IsValid() ? result_set_.Get() : 0;
 }
 
 bool SQLStatementBackend::Execute(Database* db) {
-  ASSERT(!result_set_->IsValid());
+  DCHECK(!result_set_->IsValid());
 
   // If we're re-running this statement after a quota violation, we need to
   // clear that error now
   ClearFailureDueToQuota();
 
   // This transaction might have been marked bad while it was being set up on
   // the main thread, so if there is still an error, return false.
   if (error_)
     return false;
 
@@ skipping 102 matching lines @@
   // different way, we'd use sqlite3_total_changes() here instead of
   // sqlite3_changed, because that includes rows modified from within a trigger.
   // For now, this seems sufficient.
   result_set_->SetRowsAffected(database->LastChanges());
 
   db->ReportExecuteStatementResult(0, -1, 0);  // OK
   return true;
 }
 
 void SQLStatementBackend::SetVersionMismatchedError(Database* database) {
-  ASSERT(!error_ && !result_set_->IsValid());
+  DCHECK(!error_);
+  DHCECK(!result_set_->IsValid());

[michaeln, 2017/04/10 22:59:00]

lgtm % typo here

[Hwanseung Lee, 2017/04/11 08:26:09]

Done.

   database->ReportExecuteStatementResult(7, SQLError::kVersionErr, 0);
   error_ = SQLErrorData::Create(
       SQLError::kVersionErr,
       "current version of the database and `oldVersion` argument do not match");
 }
 
 void SQLStatementBackend::SetFailureDueToQuota(Database* database) {
-  ASSERT(!error_ && !result_set_->IsValid());
+  DCHECK(!error_);
+  DCHECK(!result_set_->IsValid());
   database->ReportExecuteStatementResult(8, SQLError::kQuotaErr, 0);
   error_ = SQLErrorData::Create(SQLError::kQuotaErr,
                                 "there was not enough remaining storage "
                                 "space, or the storage quota was reached and "
                                 "the user declined to allow more space");
 }
 
 void SQLStatementBackend::ClearFailureDueToQuota() {
   if (LastExecutionFailedDueToQuota())
     error_ = nullptr;
 }
 
 bool SQLStatementBackend::LastExecutionFailedDueToQuota() const {
   return error_ && error_->Code() == SQLError::kQuotaErr;
 }
 
 }  // namespace blink