Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp

Issue 2813433002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/webdatabase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp
diff --git a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp
index ca0db499a6dbc6bc70a3e7572061692afbbe1916..83878f0a99634f6dc421fdde49fd6c1423365ed3 100644
--- a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp
+++ b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteTransaction.cpp
@@ -39,7 +39,7 @@ SQLiteTransaction::~SQLiteTransaction() {
void SQLiteTransaction::begin() {
if (!in_progress_) {
- ASSERT(!db_.transaction_in_progress_);
+ DCHECK(!db_.transaction_in_progress_);
// Call BEGIN IMMEDIATE for a write transaction to acquire
// a RESERVED lock on the DB file. Otherwise, another write
// transaction (on another connection) could make changes
@@ -57,7 +57,7 @@ void SQLiteTransaction::begin() {
void SQLiteTransaction::Commit() {
if (in_progress_) {
- ASSERT(db_.transaction_in_progress_);
+ DCHECK(db_.transaction_in_progress_);
in_progress_ = !db_.ExecuteCommand("COMMIT");
db_.transaction_in_progress_ = in_progress_;
}
@@ -70,7 +70,7 @@ void SQLiteTransaction::Rollback() {
// fail, thus returning a non-zero/true result
// (http://www.sqlite.org/lang_transaction.html).
if (in_progress_) {
- ASSERT(db_.transaction_in_progress_);
+ DCHECK(db_.transaction_in_progress_);
db_.ExecuteCommand("ROLLBACK");
in_progress_ = false;
db_.transaction_in_progress_ = false;
« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698