Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2799093006: Remove base::BinaryValue (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek, brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, posciak+watch_chromium.org, oka+watch_chromium.org, yzshen+watch_chromium.org, fukino+watch_chromium.org, tracing+reviews_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, halliwell+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, yamaguchi+watch_chromium.org, feature-media-reviews_chromium.org, fuzzing_chromium.org, oshima+watch_chromium.org, alokp+watch_chromium.org, darin (slow to review), wfh+watch_chromium.org, avayvod+watch_chromium.org, Aaron Boodman, danakj+watch_chromium.org, isheriff+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove base::BinaryValue As a follow-up to typedeffing base::BinaryValue to base::Value in http://crrev.com/2689673002 this change replaces all references to base::StringValue by base::Value. Also it adds missing #includes of base/values.h. BUG=646113 Review-Url: https://codereview.chromium.org/2799093006 Cr-Commit-Position: refs/heads/master@{#463568} Committed: https://chromium.googlesource.com/chromium/src/+/14b25da4874f20bb712e927b56d66593b5280164

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -201 lines) Patch
M base/json/json_writer_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M base/trace_event/trace_event_memory_overhead.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/values.h View 1 2 5 chunks +7 lines, -8 lines 0 comments Download
M base/values.cc View 1 2 6 chunks +10 lines, -13 lines 0 comments Download
M base/values_unittest.cc View 1 2 9 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/write_file.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/idltest/idltest_api.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/platform_keys_natives.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_rtp_stream.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_session.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/base/serializers_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_socket_utils.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/child/v8_value_converter_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/v8_value_converter_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/v8_value_converter_impl_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/android/gin_java_bridge_value.h View 3 chunks +7 lines, -8 lines 0 comments Download
M content/common/android/gin_java_bridge_value.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M content/common/android/gin_java_bridge_value_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_message_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative/declarative_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/argument_spec_unittest.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/video_frame_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_metadata.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M mojo/common/common_custom_types_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/common/values_struct_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/values_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 4 chunks +4 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/util.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
jdoerrie
rsesek@: Please review mojo/common/values_struct_traits.* brettw@: Please review the rest.
3 years, 8 months ago (2017-04-10 10:55:17 UTC) #11
Robert Sesek
LGTM
3 years, 8 months ago (2017-04-10 14:43:51 UTC) #14
brettw
lgtm
3 years, 8 months ago (2017-04-10 16:49:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799093006/40001
3 years, 8 months ago (2017-04-11 05:32:18 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 07:46:46 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/14b25da4874f20bb712e927b56d6...

Powered by Google App Engine
This is Rietveld 408576698