Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: content/browser/renderer_host/pepper/pepper_socket_utils.cc

Issue 2799093006: Remove base::BinaryValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/base/serializers_unittest.cc ('k') | content/child/v8_value_converter_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/pepper/pepper_socket_utils.cc
diff --git a/content/browser/renderer_host/pepper/pepper_socket_utils.cc b/content/browser/renderer_host/pepper/pepper_socket_utils.cc
index bf2a4c7fc08d4730bb5045927b60946382b60d0f..b749682afaa6af264ea13ebbd203ff2ec9f34903 100644
--- a/content/browser/renderer_host/pepper/pepper_socket_utils.cc
+++ b/content/browser/renderer_host/pepper/pepper_socket_utils.cc
@@ -11,6 +11,7 @@
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string_util.h"
+#include "base/values.h"
#include "build/build_config.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/content_browser_client.h"
@@ -114,8 +115,8 @@ bool GetCertificateFields(const net::X509Certificate& cert,
const std::string& serial_number = cert.serial_number();
fields->SetField(PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER,
- base::BinaryValue::CreateWithCopiedBuffer(
- serial_number.data(), serial_number.length()));
+ base::Value::CreateWithCopiedBuffer(serial_number.data(),
+ serial_number.length()));
fields->SetField(
PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE,
base::MakeUnique<base::Value>(cert.valid_start().ToDoubleT()));
@@ -126,7 +127,7 @@ bool GetCertificateFields(const net::X509Certificate& cert,
net::X509Certificate::GetDEREncoded(cert.os_cert_handle(), &der);
fields->SetField(
PP_X509CERTIFICATE_PRIVATE_RAW,
- base::BinaryValue::CreateWithCopiedBuffer(der.data(), der.length()));
+ base::Value::CreateWithCopiedBuffer(der.data(), der.length()));
return true;
}
« no previous file with comments | « chromecast/base/serializers_unittest.cc ('k') | content/child/v8_value_converter_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698