Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3691)

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 2799093006: Remove base::BinaryValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action.cc
diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc
index 1f884a0174a390d8287cb2a1f2216403f3ba1d62..00345b4c7622513825faa4b09d6850cbe214e659 100644
--- a/chrome/browser/extensions/extension_action.cc
+++ b/chrome/browser/extensions/extension_action.cc
@@ -10,6 +10,7 @@
#include "base/base64.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
+#include "base/values.h"
#include "chrome/grit/theme_resources.h"
#include "extensions/browser/extension_icon_image.h"
#include "extensions/browser/extension_icon_placeholder.h"
@@ -125,7 +126,7 @@ bool ExtensionAction::ParseIconFromCanvasDictionary(
gfx::ImageSkia* icon) {
for (base::DictionaryValue::Iterator iter(dict); !iter.IsAtEnd();
iter.Advance()) {
- const base::BinaryValue* image_data;
+ const base::Value* image_data;
std::string binary_string64;
IPC::Message pickle;
if (iter.value().GetAsBinary(&image_data)) {

Powered by Google App Engine
This is Rietveld 408576698