Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

Issue 2799093006: Remove base::BinaryValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
diff --git a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
index f86140ac688edda5a1fbba8797c59b00167dddf6..e48d9084f3b890524bb5369ec8aa21b2dc6eed00 100644
--- a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
+++ b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
@@ -263,7 +263,7 @@ class EPKChallengeMachineKeyTest : public EPKChallengeKeyTestBase {
std::unique_ptr<base::ListValue> CreateArgs() {
std::unique_ptr<base::ListValue> args(new base::ListValue);
- args->Append(base::BinaryValue::CreateWithCopiedBuffer("challenge", 9));
+ args->Append(base::Value::CreateWithCopiedBuffer("challenge", 9));
return args;
}
@@ -349,7 +349,7 @@ TEST_F(EPKChallengeMachineKeyTest, Success) {
std::unique_ptr<base::Value> value(
RunFunctionAndReturnSingleResult(func_.get(), CreateArgs(), browser()));
- const base::BinaryValue* response;
+ const base::Value* response;
ASSERT_TRUE(value->GetAsBinary(&response));
EXPECT_EQ("response",
std::string(response->GetBuffer(), response->GetSize()));
@@ -407,7 +407,7 @@ class EPKChallengeUserKeyTest : public EPKChallengeKeyTestBase {
std::unique_ptr<base::ListValue> CreateArgsInternal(bool register_key) {
std::unique_ptr<base::ListValue> args(new base::ListValue);
- args->Append(base::BinaryValue::CreateWithCopiedBuffer("challenge", 9));
+ args->Append(base::Value::CreateWithCopiedBuffer("challenge", 9));
args->AppendBoolean(register_key);
return args;
}
@@ -524,7 +524,7 @@ TEST_F(EPKChallengeUserKeyTest, Success) {
std::unique_ptr<base::Value> value(
RunFunctionAndReturnSingleResult(func_.get(), CreateArgs(), browser()));
- const base::BinaryValue* response;
+ const base::Value* response;
ASSERT_TRUE(value->GetAsBinary(&response));
EXPECT_EQ("response",
std::string(response->GetBuffer(), response->GetSize()));

Powered by Google App Engine
This is Rietveld 408576698