Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: extensions/renderer/argument_spec_unittest.cc

Issue 2799093006: Remove base::BinaryValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/web_request/upload_data_presenter_unittest.cc ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/argument_spec_unittest.cc
diff --git a/extensions/renderer/argument_spec_unittest.cc b/extensions/renderer/argument_spec_unittest.cc
index 7bdda59099ac56ace971c7093bea8e8e23abe9f9..a580a74549f0e9d8c749257a8af8c50fce00d3b3 100644
--- a/extensions/renderer/argument_spec_unittest.cc
+++ b/extensions/renderer/argument_spec_unittest.cc
@@ -303,18 +303,16 @@ TEST_F(ArgumentSpecUnitTest, Test) {
{
// A non-empty (but zero-filled) ArrayBufferView.
const char kBuffer[] = {0, 0, 0, 0};
- std::unique_ptr<base::BinaryValue> expected_value =
- base::BinaryValue::CreateWithCopiedBuffer(kBuffer,
- arraysize(kBuffer));
+ std::unique_ptr<base::Value> expected_value =
+ base::Value::CreateWithCopiedBuffer(kBuffer, arraysize(kBuffer));
ASSERT_TRUE(expected_value);
ExpectSuccessWithNoConversion(spec, "(new Int32Array(2))");
}
{
// Actual data.
const char kBuffer[] = {'p', 'i', 'n', 'g'};
- std::unique_ptr<base::BinaryValue> expected_value =
- base::BinaryValue::CreateWithCopiedBuffer(kBuffer,
- arraysize(kBuffer));
+ std::unique_ptr<base::Value> expected_value =
+ base::Value::CreateWithCopiedBuffer(kBuffer, arraysize(kBuffer));
ASSERT_TRUE(expected_value);
ExpectSuccess(spec,
"var b = new ArrayBuffer(4);\n"
« no previous file with comments | « extensions/browser/api/web_request/upload_data_presenter_unittest.cc ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698