Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 2799093006: Remove base::BinaryValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
index ba11fc855e71a345e66a22023edc1dc4a2a14d95..f40e178c2fa0c8bb7a66c94cb74cf325002e83ee 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
@@ -27,6 +27,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
+#include "base/values.h"
#include "chrome/browser/content_settings/cookie_settings_factory.h"
#include "chrome/browser/extensions/event_router_forwarder.h"
#include "chrome/browser/net/chrome_extensions_network_delegate.h"
@@ -66,7 +67,6 @@ namespace helpers = extension_web_request_api_helpers;
namespace keys = extension_web_request_api_constants;
namespace web_request = extensions::api::web_request;
-using base::BinaryValue;
using base::DictionaryValue;
using base::ListValue;
using base::Time;
@@ -610,15 +610,13 @@ TEST_F(ExtensionWebRequestTest, AccessRequestBodyData) {
base::ListValue raw;
extensions::subtle::AppendKeyValuePair(
keys::kRequestBodyRawBytesKey,
- BinaryValue::CreateWithCopiedBuffer(kPlainBlock1, kPlainBlock1Length),
- &raw);
+ Value::CreateWithCopiedBuffer(kPlainBlock1, kPlainBlock1Length), &raw);
extensions::subtle::AppendKeyValuePair(
keys::kRequestBodyRawFileKey,
base::MakeUnique<base::Value>(std::string()), &raw);
extensions::subtle::AppendKeyValuePair(
keys::kRequestBodyRawBytesKey,
- BinaryValue::CreateWithCopiedBuffer(kPlainBlock2, kPlainBlock2Length),
- &raw);
+ Value::CreateWithCopiedBuffer(kPlainBlock2, kPlainBlock2Length), &raw);
// Summary.
const base::Value* const kExpected[] = {
form_data.get(),
« no previous file with comments | « chrome/browser/extensions/api/platform_keys/platform_keys_api.cc ('k') | chrome/browser/extensions/extension_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698