Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/json_schema_compiler/util.cc

Issue 2799093006: Remove base::BinaryValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/util.cc
diff --git a/tools/json_schema_compiler/util.cc b/tools/json_schema_compiler/util.cc
index 9f4286a7526257230887c5530dd05a24f4fec467..983dc6682855f241207249a5247d36aa0da1d818 100644
--- a/tools/json_schema_compiler/util.cc
+++ b/tools/json_schema_compiler/util.cc
@@ -69,7 +69,7 @@ bool PopulateItem(const base::Value& from,
}
bool PopulateItem(const base::Value& from, std::vector<char>* out) {
- const base::BinaryValue* binary = nullptr;
+ const base::Value* binary = nullptr;
if (!from.GetAsBinary(&binary))
return false;
out->assign(binary->GetBuffer(), binary->GetBuffer() + binary->GetSize());
@@ -79,7 +79,7 @@ bool PopulateItem(const base::Value& from, std::vector<char>* out) {
bool PopulateItem(const base::Value& from,
std::vector<char>* out,
base::string16* error) {
- const base::BinaryValue* binary = nullptr;
+ const base::Value* binary = nullptr;
if (!from.GetAsBinary(&binary))
return ReportError(from, base::Value::Type::BINARY, error);
out->assign(binary->GetBuffer(), binary->GetBuffer() + binary->GetSize());
@@ -134,8 +134,7 @@ void AddItemToList(const std::string& from, base::ListValue* out) {
}
void AddItemToList(const std::vector<char>& from, base::ListValue* out) {
- out->Append(
- base::BinaryValue::CreateWithCopiedBuffer(from.data(), from.size()));
+ out->Append(base::Value::CreateWithCopiedBuffer(from.data(), from.size()));
}
void AddItemToList(const std::unique_ptr<base::Value>& from,
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698