Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: content/child/v8_value_converter_impl_unittest.cc

Issue 2799093006: Remove base::BinaryValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/android/gin_java_bridge_value.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/v8_value_converter_impl_unittest.cc
diff --git a/content/child/v8_value_converter_impl_unittest.cc b/content/child/v8_value_converter_impl_unittest.cc
index 394af66db0f36528d05dcd570cf49a9a4ebe3478..a04e8ac33596865f783d6846117ea0bbe3aaeb09 100644
--- a/content/child/v8_value_converter_impl_unittest.cc
+++ b/content/child/v8_value_converter_impl_unittest.cc
@@ -1148,8 +1148,7 @@ TEST_F(V8ValueConverterImplTest, StrategyBypass) {
converter.FromV8Value(array_buffer, context));
ASSERT_TRUE(binary_value);
std::unique_ptr<base::Value> reference_binary_value(
- base::BinaryValue::CreateWithCopiedBuffer(kExampleData,
- sizeof(kExampleData)));
+ base::Value::CreateWithCopiedBuffer(kExampleData, sizeof(kExampleData)));
EXPECT_TRUE(
base::Value::Equals(reference_binary_value.get(), binary_value.get()));
@@ -1159,7 +1158,7 @@ TEST_F(V8ValueConverterImplTest, StrategyBypass) {
converter.FromV8Value(array_buffer_view, context));
ASSERT_TRUE(binary_view_value);
std::unique_ptr<base::Value> reference_binary_view_value(
- base::BinaryValue::CreateWithCopiedBuffer(&kExampleData[1], 3));
+ base::Value::CreateWithCopiedBuffer(&kExampleData[1], 3));
EXPECT_TRUE(base::Value::Equals(reference_binary_view_value.get(),
binary_view_value.get()));
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/android/gin_java_bridge_value.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698