chrome/browser/chromeos/file_system_provider/operations/write_file.cc - Issue 2799093006: Remove base::BinaryValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/write_file.cc

Issue 2799093006: Remove base::BinaryValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc ('k') | chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/write_file.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/write_file.cc b/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

index 528ca4b927e25b8c031f079acb1b3ae7cc47fc08..118155da2996552e903934b530966e238fd11bf1 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/write_file.cc

@@ -50,8 +50,7 @@ bool WriteFile::Execute(int request_id) {

DCHECK(buffer_.get());

std::unique_ptr<base::DictionaryValue> options_as_value = options.ToValue();

options_as_value->Set(

- "data",

- base::BinaryValue::CreateWithCopiedBuffer(buffer_->data(), length_));

+ "data", base::Value::CreateWithCopiedBuffer(buffer_->data(), length_));

std::unique_ptr<base::ListValue> event_args(new base::ListValue);

event_args->Append(std::move(options_as_value));