📱 Simplify naming of generated java enums IntDefs

[Android] Simplify naming of generated java enums IntDefs

Allows to use @EnumType as IntDef annotation instead of
@EnumType.EnumTypeEnum

BUG=707186
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2792583002
Cr-Commit-Position: refs/heads/master@{#463490}
Committed: https://chromium.googlesource.com/chromium/src/+/14f477472e0e8612c98763b68e9a51bcae954c24

[dgn, 2017-03-31 13:40:31]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 13:40:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2017-03-31 13:56:09]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2017-03-31 13:56:10]

PTAL

[commit-bot: I haz the power, 2017-03-31 13:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 13:57:06]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Bernhard Bauer, 2017-03-31 14:05:57]

bauerb@chromium.org changed reviewers:
+ peconn@chromium.org

[Bernhard Bauer, 2017-03-31 14:05:58]

LGTM if it works, but I had the suspicion there was a reason not to do it like
this in the first place. Peter, do you remember?

[PEConn, 2017-03-31 14:14:02]

On 2017/03/31 14:05:58, Bernhard Bauer wrote:
> LGTM if it works, but I had the suspicion there was a reason not to do it like
> this in the first place. Peter, do you remember?

I can't see off the top of my head why it wouldn't work, LGTM.

[dgn, 2017-03-31 14:24:20]

Description was changed from

==========
[Android] Simplify naming of generated java enums IntDefs

Allows to use @EnumType as IntDef annotation instead of
@EnumType.EnumTypeEnum

BUG=707186
==========

to

==========
[Android] Simplify naming of generated java enums IntDefs

Allows to use @EnumType as IntDef annotation instead of
@EnumType.EnumTypeEnum

BUG=707186
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[dgn, 2017-03-31 14:26:25]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 14:26:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 15:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 15:23:48]

Dry run: This issue passed the CQ dry run.

[dgn, 2017-03-31 16:50:10]

dgn@chromium.org changed reviewers:
+ agrieve@chromium.org, fgorski@chromium.org, jyasskin@chromium.org,
pauljensen@chromium.org, sgurun@chromium.org

[dgn, 2017-03-31 16:50:10]

PTAL. Most of the changes are just updating imports and annotation names.

agrieve@chromium.org: Please review changes in //build/android (the real
changes) and //base/android

jyasskin@chromium.org: Please review changes in //components/location

fgorski@chromium.org: Please review changes in
//components/offline_items_collection

pauljensen@chromium.org: Please review changes in //components/cronet and //net

sgurun@chromium.org: Please review changes in //android_webview

[pauljensen, 2017-03-31 17:08:54]

lgtm

[sgurun-gerrit only, 2017-03-31 17:15:32]

there is a downstream dependency, which also needs to be fixed.

that said LGTM

[dgn, 2017-03-31 17:23:46]

On 2017/03/31 17:15:32, sgurun wrote:
> there is a downstream dependency, which also needs to be fixed.
> 
> that said LGTM

Indeed, I have https://chrome-internal-review.googlesource.com/c/343143/ ready

[agrieve, 2017-04-01 01:00:20]

On 2017/03/31 17:23:46, dgn wrote:
> On 2017/03/31 17:15:32, sgurun wrote:
> > there is a downstream dependency, which also needs to be fixed.
> > 
> > that said LGTM
> 
> Indeed, I have https://chrome-internal-review.googlesource.com/c/343143/ ready

nice! lgtm

[dgn, 2017-04-05 17:56:31]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 17:56:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:55:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[fgorski, 2017-04-05 21:19:01]

offline_item_collection lgtm

[Jeffrey Yasskin, 2017-04-06 19:01:50]

lgtm for components/location.

[dgn, 2017-04-07 10:51:06]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 10:51:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 12:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 12:50:05]

Dry run: This issue passed the CQ dry run.

[dgn, 2017-04-11 00:15:55]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 00:16:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 01:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:20:18]

Dry run: This issue passed the CQ dry run.

[dgn, 2017-04-11 01:27:54]

The CQ bit was checked by dgn@chromium.org

[dgn, 2017-04-11 01:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
peconn@chromium.org, sgurun@chromium.org, agrieve@chromium.org,
pauljensen@chromium.org, fgorski@chromium.org, jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/2792583002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-11 01:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 01:38:55]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491874074089960,
"parent_rev": "1d178abfe10547606cdd5921c2ea097e1b648757", "commit_rev":
"14f477472e0e8612c98763b68e9a51bcae954c24"}

[commit-bot: I haz the power, 2017-04-11 01:44:01]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491874074089960,
"parent_rev": "1d178abfe10547606cdd5921c2ea097e1b648757", "commit_rev":
"14f477472e0e8612c98763b68e9a51bcae954c24"}

[commit-bot: I haz the power, 2017-04-11 01:44:34]

Description was changed from

==========
[Android] Simplify naming of generated java enums IntDefs

Allows to use @EnumType as IntDef annotation instead of
@EnumType.EnumTypeEnum

BUG=707186
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Android] Simplify naming of generated java enums IntDefs

Allows to use @EnumType as IntDef annotation instead of
@EnumType.EnumTypeEnum

BUG=707186
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2792583002
Cr-Commit-Position: refs/heads/master@{#463490}
Committed:
https://chromium.googlesource.com/chromium/src/+/14f477472e0e8612c98763b68e9a...
==========

[commit-bot: I haz the power, 2017-04-11 01:44:36]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/14f477472e0e8612c98763b68e9a...