Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3885)

Unified Diff: build/android/gyp/java_cpp_enum_tests.py

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/java_cpp_enum_tests.py
diff --git a/build/android/gyp/java_cpp_enum_tests.py b/build/android/gyp/java_cpp_enum_tests.py
index f0018a18f9af2ea63e8aed47d94fa2d23625005d..8d9e60de698d6699072b1efd22e8491bfdc9a8d7 100755
--- a/build/android/gyp/java_cpp_enum_tests.py
+++ b/build/android/gyp/java_cpp_enum_tests.py
@@ -51,21 +51,20 @@ import android.support.annotation.IntDef;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
-public class ClassName {
- @IntDef({
- E1, E2
- })
- @Retention(RetentionPolicy.SOURCE)
- public @interface ClassNameEnum {}
+@IntDef({
+ ClassName.E1, ClassName.E2
+})
+@Retention(RetentionPolicy.SOURCE)
+public @interface ClassName {
/**
* %s
* really really long.
*/
- public static final int E1 = 1;
+ int E1 = 1;
/**
* This is a comment.
*/
- public static final int E2 = 2 << 2;
+ int E2 = 2 << 2;
}
"""
long_comment = ('This is a multiple line comment that is really long. '

Powered by Google App Engine
This is Rietveld 408576698