chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java - Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

index 154499e5fe18ee4e18eb16089f9f7f0559675d89..8b5be57a796ea01a3b8b20542f6d5077375b9c63 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java

@@ -46,7 +46,6 @@

import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

import org.chromium.chrome.browser.offlinepages.OfflinePageItem;

import org.chromium.chrome.browser.suggestions.ContentSuggestionsAdditionalAction;

-import org.chromium.chrome.browser.suggestions.ContentSuggestionsAdditionalAction.ContentSuggestionsAdditionalActionEnum;

import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;

import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;

import org.chromium.chrome.browser.suggestions.SuggestionsRanker;

@@ -745,7 +744,7 @@ private OfflinePageItem createOfflinePageItem(String url, long offlineId) {

}

private static void verifyAction(

- SuggestionsSection section, @ContentSuggestionsAdditionalActionEnum int action) {

+ SuggestionsSection section, @ContentSuggestionsAdditionalAction int action) {

SuggestionsSource suggestionsSource = mock(SuggestionsSource.class);

SuggestionsUiDelegate manager = mock(SuggestionsUiDelegate.class);

SuggestionsNavigationDelegate navDelegate = mock(SuggestionsNavigationDelegate.class);