chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java - Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsSource.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java

index 27bbad0217962d6f76765f605a0f2cecb645c61e..348d940333fec768ec64a187cba7e7e4b1c46f56 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java

@@ -12,7 +12,7 @@

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.chrome.browser.AppHooks;

-import org.chromium.components.location.LocationSettingsDialogContext.LocationSettingsDialogContextEnum;

+import org.chromium.components.location.LocationSettingsDialogContext;

import org.chromium.components.location.LocationSettingsDialogOutcome;

import org.chromium.components.location.LocationUtils;

import org.chromium.content_public.browser.WebContents;

@@ -72,7 +72,7 @@ private static boolean canPromptToEnableSystemLocationSetting() {

@CalledByNative

private static void promptToEnableSystemLocationSetting(

- @LocationSettingsDialogContextEnum int promptContext, WebContents webContents,

+ @LocationSettingsDialogContext int promptContext, WebContents webContents,

final long nativeCallback) {

WindowAndroid window = webContents.getTopLevelNativeWindow();

if (window == null) {