chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java - Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

index ea653ce93892e4a0bf37f0c5178fb7f60a99b632..673ab870562b7d53cee00403ebcd22d1c9ce37ab 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

@@ -77,7 +77,7 @@ public void onResult(Integer result) {

mInstallDelegate.installAsync(packageName, version, title, token, url, callback);

}

- private void notify(@WebApkInstallResult.WebApkInstallResultEnum int result) {

+ private void notify(@WebApkInstallResult int result) {

if (mNativePointer != 0) {

nativeOnInstallFinished(mNativePointer, result);

}

@@ -114,5 +114,5 @@ private boolean isWebApkInstalled(String packageName) {

}

private native void nativeOnInstallFinished(

- long nativeWebApkInstaller, @WebApkInstallResult.WebApkInstallResultEnum int result);

+ long nativeWebApkInstaller, @WebApkInstallResult int result);

}