chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java - Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java

index b8d20edf55f010949396517c7516d6271de9606a..9209b63e636a7a0f346da70889fd0427cf971556 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/FakeSuggestionsSource.java

@@ -11,7 +11,6 @@

import org.chromium.chrome.browser.ntp.cards.SuggestionsCategoryInfo;

import org.chromium.chrome.browser.ntp.snippets.CategoryInt;

import org.chromium.chrome.browser.ntp.snippets.CategoryStatus;

-import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;

import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

@@ -46,7 +45,7 @@

/**

* Sets the status to be returned for a given category.

- public void setStatusForCategory(@CategoryInt int category, @CategoryStatusEnum int status) {

+ public void setStatusForCategory(@CategoryInt int category, @CategoryStatus int status) {

mCategoryStatus.put(category, status);

if (status == CategoryStatus.NOT_PROVIDED) {

mCategories.remove(Integer.valueOf(category));

@@ -194,7 +193,7 @@ public void setObserver(Observer observer) {

return result;

}

- @CategoryStatusEnum

+ @CategoryStatus

@Override

public int getCategoryStatus(@CategoryInt int category) {

return mCategoryStatus.get(category);