chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java - Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java

index 32d6a973b68f1253a198d9f2417891fd8644c279..78dacb10c4fbd1fb09c033f3f10fc6f0c0a647dc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSitesBridge.java

@@ -6,8 +6,6 @@

import org.chromium.base.annotations.JNIAdditionalImport;

import org.chromium.chrome.browser.profiles.Profile;

-import org.chromium.chrome.browser.suggestions.TileSource.TileSourceEnum;

-import org.chromium.chrome.browser.suggestions.TileVisualType.TileVisualTypeEnum;

/**

* Methods to bridge into native history to provide most recent urls, titles and thumbnails.

@@ -74,7 +72,7 @@ public void recordPageImpression(int[] tileTypes, int[] sources, String[] tileUr

@Override

public void recordOpenedMostVisitedItem(

- int index, @TileVisualTypeEnum int type, @TileSourceEnum int source) {

+ int index, @TileVisualType int type, @TileSource int source) {

nativeRecordOpenedMostVisitedItem(mNativeMostVisitedSitesBridge, index, type, source);

}