Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
index 1f77745c23876a4a66822cafbecf6123ad58b4e1..bc0abf84d5a45e55cb49d0f089ccd2db94dcd6a3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
@@ -7,9 +7,6 @@
import android.graphics.drawable.Drawable;
import android.support.annotation.Nullable;
-import org.chromium.chrome.browser.suggestions.TileSource.TileSourceEnum;
-import org.chromium.chrome.browser.suggestions.TileVisualType.TileVisualTypeEnum;
-
/**
* Holds the details to populate a site suggestion tile.
*/
@@ -19,10 +16,10 @@
private final String mWhitelistIconPath;
private final int mIndex;
- @TileSourceEnum
+ @TileSource
private final int mSource;
- @TileVisualTypeEnum
+ @TileVisualType
private int mType = TileVisualType.NONE;
@Nullable
@@ -39,8 +36,8 @@
* @param index The index of this tile in the list of tiles.
* @param source The {@code TileSource} that generated this tile.
*/
- public Tile(String title, String url, String whitelistIconPath, int index,
- @TileSourceEnum int source) {
+ public Tile(
+ String title, String url, String whitelistIconPath, int index, @TileSource int source) {
mTitle = title;
mUrl = url;
mWhitelistIconPath = whitelistIconPath;
@@ -126,7 +123,7 @@ public int getIndex() {
* @return The source of this tile. Used for metrics tracking. Valid values are listed in
* {@code TileSource}.
*/
- @TileSourceEnum
+ @TileSource
public int getSource() {
return mSource;
}
@@ -134,7 +131,7 @@ public int getSource() {
/**
* @return The visual type of this tile. Valid values are listed in {@link TileVisualType}.
*/
- @TileVisualTypeEnum
+ @TileVisualType
public int getType() {
return mType;
}
@@ -143,7 +140,7 @@ public int getType() {
* Sets the visual type of this tile. Valid values are listed in
* {@link TileVisualType}.
*/
- public void setType(@TileVisualTypeEnum int type) {
+ public void setType(@TileVisualType int type) {
mType = type;
}

Powered by Google App Engine
This is Rietveld 408576698