components/location/android/java/src/org/chromium/components/location/LocationUtils.java - Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/location/android/java/src/org/chromium/components/location/LocationUtils.java

Issue 2792583002: 📱 Simplify naming of generated java enums IntDefs (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/location/android/java/src/org/chromium/components/location/LocationUtils.java

diff --git a/components/location/android/java/src/org/chromium/components/location/LocationUtils.java b/components/location/android/java/src/org/chromium/components/location/LocationUtils.java

index 22391a73d1dc38dfa0991c8a5c80fe8a489d2b4c..c0de175a1abac352925a02ee7afcfe34b02ffe1a 100644

--- a/components/location/android/java/src/org/chromium/components/location/LocationUtils.java

+++ b/components/location/android/java/src/org/chromium/components/location/LocationUtils.java

@@ -19,8 +19,6 @@

import org.chromium.base.ThreadUtils;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.SuppressFBWarnings;

-import org.chromium.components.location.LocationSettingsDialogContext.LocationSettingsDialogContextEnum;

-import org.chromium.components.location.LocationSettingsDialogOutcome.LocationSettingsDialogOutcomeEnum;

import org.chromium.ui.base.WindowAndroid;

/**

@@ -107,8 +105,8 @@ public boolean canPromptToEnableSystemLocationSetting() {

* dialog, which in practice happens very infrequently since the dialog is modal.

public void promptToEnableSystemLocationSetting(

- @LocationSettingsDialogContextEnum int promptContext, WindowAndroid window,

- @LocationSettingsDialogOutcomeEnum Callback<Integer> callback) {

+ @LocationSettingsDialogContext int promptContext, WindowAndroid window,

+ @LocationSettingsDialogOutcome Callback<Integer> callback) {

callback.onResult(LocationSettingsDialogOutcome.NO_PROMPT);

}