Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 277143003: Add NavigateToPage API for action_runner. (Closed)

Created:
6 years, 7 months ago by nednguyen
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, telemetry+watch_chromium.org, jam, darin-cc_chromium.org, chrishenry
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add NavigateToPage API for action_runner. Remove page parameter from PageAction.RunAction(). BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272141

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -197 lines) Patch
M content/test/gpu/gpu_tests/context_lost.py View 3 chunks +3 lines, -3 lines 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_robustness.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/page_sets/gpu_rasterization_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/memory_tests.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/maps.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/polymer_load.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/browser_control_click.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/calendar_forward_backward.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/chrome_proxy/safebrowsing.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/chrome_proxy/smoke.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/gmail_alt_threadlist_conversation.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/gmail_alt_two_labels.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/gmail_compose_discard.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/gmail_expand_collapse_conversation.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/image_decoding_measurement.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/indexeddb_offline.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 12 chunks +12 lines, -12 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 10 chunks +10 lines, -10 lines 0 comments Download
M tools/perf/page_sets/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/mse_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/plus_alt_posts_photos.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/polymer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/top_25.py View 11 chunks +11 lines, -11 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_canvas_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_compositor_cases.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_energy_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_pinch_zoom_cases.py View 9 chunks +9 lines, -9 lines 0 comments Download
M tools/perf/page_sets/tough_webgl_cases.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 2 chunks +19 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/all_page_actions.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/gesture_action.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/gesture_action_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/interact.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript_click.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript_click_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/js_collect_garbage.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/loop.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/loop_unittest.py View 3 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/media_action.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/navigate.py View 1 chunk +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/navigate_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/page_action.py View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/pinch.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/play.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/play_unittest.py View 6 chunks +14 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/reload.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/repaint_continuously.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_bounce.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/seek.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/seek_unittest.py View 4 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/swipe.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/tap.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/wait.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/wait_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/wait_until.py View 1 chunk +5 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/page.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nednguyen
I know that this change is quite big, but that does provide some context to ...
6 years, 7 months ago (2014-05-10 18:24:52 UTC) #1
nduca
lgtm
6 years, 7 months ago (2014-05-21 21:29:52 UTC) #2
Ken Russell (switch to Gerrit)
content/test/gpu LGTM
6 years, 7 months ago (2014-05-21 23:43:28 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-21 23:53:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/277143003/20001
6 years, 7 months ago (2014-05-21 23:57:36 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 08:26:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 272141

Powered by Google App Engine
This is Rietveld 408576698