tools/telemetry/telemetry/page/page_test.py - Issue 277143003: Add NavigateToPage API for action_runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 277143003: Add NavigateToPage API for action_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_test.py

diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py

index 4e04bb19f12ab21b0193eef9b844d47b74e2d26f..4a8497b6e8a6d53edaa54b41fd6f8d9235f18cd8 100644

--- a/tools/telemetry/telemetry/page/page_test.py

+++ b/tools/telemetry/telemetry/page/page_test.py

@@ -234,7 +234,7 @@ class PageTest(command_line.Command):

def RunPage(self, page, tab, results):

# Run actions.

interactive = self.options and self.options.interactive

- action_runner = action_runner_module.ActionRunner(page, tab, self)

+ action_runner = action_runner_module.ActionRunner(tab)

self.WillRunActions(page, tab)

if interactive:

action_runner.RunAction(interact.InteractAction())

@@ -255,7 +255,7 @@ class PageTest(command_line.Command):

Runs the 'navigate_steps' page attribute as a compound action.

"""

- action_runner = action_runner_module.ActionRunner(page, tab, None)

+ action_runner = action_runner_module.ActionRunner(tab)

page.RunNavigateSteps(action_runner)

def IsExiting(self):

« no previous file with comments | « tools/telemetry/telemetry/page/page.py ('k') | tools/telemetry/telemetry/page/record_wpr.py » ('j') | no next file with comments »