tools/telemetry/telemetry/page/actions/scroll_bounce.py - Issue 277143003: Add NavigateToPage API for action_runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/scroll_bounce.py

Issue 277143003: Add NavigateToPage API for action_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/scroll_bounce.py

diff --git a/tools/telemetry/telemetry/page/actions/scroll_bounce.py b/tools/telemetry/telemetry/page/actions/scroll_bounce.py

index 755a1f343174ac61c0e71b3128f7ae018fe5a6e4..6bdd25f212fff3823aca1949b311f277fd16301f 100644

--- a/tools/telemetry/telemetry/page/actions/scroll_bounce.py

+++ b/tools/telemetry/telemetry/page/actions/scroll_bounce.py

@@ -10,7 +10,7 @@ class ScrollBounceAction(GestureAction):

def __init__(self, attributes=None):

super(ScrollBounceAction, self).__init__(attributes)

- def WillRunAction(self, page, tab):

+ def WillRunAction(self, tab):

for js_file in ['gesture_common.js', 'scroll_bounce.js']:

with open(os.path.join(os.path.dirname(__file__), js_file)) as f:

js = f.read()

@@ -39,7 +39,7 @@ class ScrollBounceAction(GestureAction):

window.__scrollBounceAction = new __ScrollBounceAction(%s);"""

% (done_callback))

- def RunGesture(self, page, tab):

+ def RunGesture(self, tab):

left_start_percentage = 0.5

top_start_percentage = 0.5

direction = 'down'