tools/telemetry/telemetry/page/actions/javascript_click_unittest.py - Issue 277143003: Add NavigateToPage API for action_runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/javascript_click_unittest.py

Issue 277143003: Add NavigateToPage API for action_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/actions/javascript_click.py ('k') | tools/telemetry/telemetry/page/actions/js_collect_garbage.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/actions/javascript_click_unittest.py

diff --git a/tools/telemetry/telemetry/page/actions/javascript_click_unittest.py b/tools/telemetry/telemetry/page/actions/javascript_click_unittest.py

index 771730d2a6577c85ee1ae9e0a620f4347b2df0f9..fba168258a6504b67a4ce232223d7bbf19b7a8a8 100644

--- a/tools/telemetry/telemetry/page/actions/javascript_click_unittest.py

+++ b/tools/telemetry/telemetry/page/actions/javascript_click_unittest.py

@@ -18,7 +18,7 @@ class ClickElementActionTest(tab_test_case.TabTestCase):

i = javascript_click.ClickElementAction(data)

data = {'condition': 'href_change'}

j = wait_until.WaitUntil(i, data)

- j.RunActionAndWait(None, self._tab)

+ j.RunActionAndWait(self._tab)

self.assertEquals(

self._tab.EvaluateJavaScript('document.location.pathname;'),

@@ -34,7 +34,7 @@ class ClickElementActionTest(tab_test_case.TabTestCase):

i = javascript_click.ClickElementAction(data)

data = {'condition': 'href_change'}

j = wait_until.WaitUntil(i, data)

- j.RunActionAndWait(None, self._tab)

+ j.RunActionAndWait(self._tab)

self.assertEquals(

self._tab.EvaluateJavaScript('document.location.pathname;'),

@@ -50,7 +50,7 @@ class ClickElementActionTest(tab_test_case.TabTestCase):

i = javascript_click.ClickElementAction(data)

data = {'condition': 'href_change'}

j = wait_until.WaitUntil(i, data)

- j.RunActionAndWait(None, self._tab)

+ j.RunActionAndWait(self._tab)

self.assertEquals(

self._tab.EvaluateJavaScript('document.location.pathname;'),

@@ -66,7 +66,7 @@ class ClickElementActionTest(tab_test_case.TabTestCase):

i = javascript_click.ClickElementAction(data)

data = {'condition': 'href_change'}

j = wait_until.WaitUntil(i, data)

- j.RunActionAndWait(None, self._tab)

+ j.RunActionAndWait(self._tab)

self.assertEquals(

self._tab.EvaluateJavaScript('document.location.pathname;'),