Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/telemetry/telemetry/page/actions/page_action.py

Issue 277143003: Add NavigateToPage API for action_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/page_action.py
diff --git a/tools/telemetry/telemetry/page/actions/page_action.py b/tools/telemetry/telemetry/page/actions/page_action.py
index 5b784673b9be8cd617f63bcd48788913b47a3653..e7b95a801fa71fe42625ad68ad56f9d85ffb4573 100644
--- a/tools/telemetry/telemetry/page/actions/page_action.py
+++ b/tools/telemetry/telemetry/page/actions/page_action.py
@@ -22,7 +22,7 @@ class PageAction(object):
else:
self.wait_until = None
- def WillRunAction(self, page, tab):
+ def WillRunAction(self, tab):
"""Override to do action-specific setup before
Test.WillRunAction is called."""
pass
@@ -30,16 +30,16 @@ class PageAction(object):
def WillWaitAfterRun(self):
return self.wait_until is not None
- def RunActionAndMaybeWait(self, page, tab):
+ def RunActionAndMaybeWait(self, tab):
if self.wait_until:
- self.wait_until.RunActionAndWait(page, tab)
+ self.wait_until.RunActionAndWait(tab)
else:
- self.RunAction(page, tab)
+ self.RunAction(tab)
- def RunAction(self, page, tab):
+ def RunAction(self, tab):
raise NotImplementedError()
- def CleanUp(self, page, tab):
+ def CleanUp(self, tab):
pass
def CanBeBound(self):
« no previous file with comments | « tools/telemetry/telemetry/page/actions/navigate_unittest.py ('k') | tools/telemetry/telemetry/page/actions/pinch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698