Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: tools/telemetry/telemetry/page/actions/gesture_action.py

Issue 277143003: Add NavigateToPage API for action_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/gesture_action.py
diff --git a/tools/telemetry/telemetry/page/actions/gesture_action.py b/tools/telemetry/telemetry/page/actions/gesture_action.py
index 993c76a76fc52e71974d1eac4dd88cd680e7ac0e..1850672687e30f2518c6c04dcfb2b1bf53ad9e7c 100644
--- a/tools/telemetry/telemetry/page/actions/gesture_action.py
+++ b/tools/telemetry/telemetry/page/actions/gesture_action.py
@@ -22,8 +22,8 @@ class GestureAction(page_action.PageAction):
assert self.wait_until is None or self.wait_action is None, (
'gesture cannot have wait_after and wait_until at the same time.')
- def RunAction(self, page, tab):
- runner = action_runner.ActionRunner(None, tab)
+ def RunAction(self, tab):
+ runner = action_runner.ActionRunner(tab)
if self.wait_action:
interaction_name = 'Action_%s' % self.__class__.__name__
else:
@@ -32,14 +32,14 @@ class GestureAction(page_action.PageAction):
if self.automatically_record_interaction:
runner.BeginInteraction(interaction_name, [tir_module.IS_SMOOTH])
- self.RunGesture(page, tab)
+ self.RunGesture(tab)
if self.wait_action:
- self.wait_action.RunAction(page, tab)
+ self.wait_action.RunAction(tab)
if self.automatically_record_interaction:
runner.EndInteraction(interaction_name, [tir_module.IS_SMOOTH])
- def RunGesture(self, page, tab):
+ def RunGesture(self, tab):
raise NotImplementedError()
@staticmethod

Powered by Google App Engine
This is Rietveld 408576698