tools/telemetry/telemetry/page/actions/scroll_unittest.py - Issue 277143003: Add NavigateToPage API for action_runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/scroll_unittest.py

Issue 277143003: Add NavigateToPage API for action_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/scroll_unittest.py

diff --git a/tools/telemetry/telemetry/page/actions/scroll_unittest.py b/tools/telemetry/telemetry/page/actions/scroll_unittest.py

index d4630381dc89ef1f26ea5aac832a0e3b49afdd59..a60b089b60e6362a9cbce5c6007d80991f5f5a3c 100644

--- a/tools/telemetry/telemetry/page/actions/scroll_unittest.py

+++ b/tools/telemetry/telemetry/page/actions/scroll_unittest.py

@@ -40,7 +40,7 @@ class ScrollActionTest(tab_test_case.TabTestCase):

|| document.body.scrollTop"""), 0)

i = scroll.ScrollAction()

- i.WillRunAction(page, self._tab)

+ i.WillRunAction(self._tab)

self._tab.ExecuteJavaScript("""

window.__scrollAction.beginMeasuringHook = function() {

@@ -49,7 +49,7 @@ class ScrollActionTest(tab_test_case.TabTestCase):

window.__scrollAction.endMeasuringHook = function() {

window.__didEndMeasuring = true;

};""")

- i.RunAction(page, self._tab)

+ i.RunAction(self._tab)

self.assertTrue(self._tab.EvaluateJavaScript('window.__didBeginMeasuring'))

self.assertTrue(self._tab.EvaluateJavaScript('window.__didEndMeasuring'))