Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: tools/telemetry/telemetry/page/actions/loop_unittest.py

Issue 277143003: Add NavigateToPage API for action_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/loop_unittest.py
diff --git a/tools/telemetry/telemetry/page/actions/loop_unittest.py b/tools/telemetry/telemetry/page/actions/loop_unittest.py
index b547961de3d2183ac7dadfa6e4b5233326e41c02..628f43cedac29073df475cf0292a318240f48f07 100644
--- a/tools/telemetry/telemetry/page/actions/loop_unittest.py
+++ b/tools/telemetry/telemetry/page/actions/loop_unittest.py
@@ -23,8 +23,8 @@ class LoopActionTest(tab_test_case.TabTestCase):
"""Tests that with no selector Loop action loops first media element."""
data = {'selector': '#video_1', 'loop_count': 2}
action = loop.LoopAction(data)
- action.WillRunAction(None, self._tab)
- action.RunAction(None, self._tab)
+ action.WillRunAction(self._tab)
+ action.RunAction(self._tab)
# Assert only first video has played.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_LOOP_CHECK))
@@ -34,11 +34,11 @@ class LoopActionTest(tab_test_case.TabTestCase):
"""Tests that Loop action loops all video elements with selector='all'."""
data = {'selector': 'all', 'loop_count': 2}
action = loop.LoopAction(data)
- action.WillRunAction(None, self._tab)
+ action.WillRunAction(self._tab)
# Both videos not playing before running action.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_LOOP_CHECK))
- action.RunAction(None, self._tab)
+ action.RunAction(self._tab)
# Assert all media elements played.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
self.assertTrue(self._tab.EvaluateJavaScript(AUDIO_1_LOOP_CHECK))
@@ -50,14 +50,14 @@ class LoopActionTest(tab_test_case.TabTestCase):
'wait_timeout': 1,
'loop_count': 2}
action = loop.LoopAction(data)
- action.WillRunAction(None, self._tab)
+ action.WillRunAction(self._tab)
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_LOOP_CHECK))
- self.assertRaises(util.TimeoutException, action.RunAction, None, self._tab)
+ self.assertRaises(util.TimeoutException, action.RunAction, self._tab)
@decorators.Disabled('android')
def testLoopWithoutLoopCount(self):
"""Tests that loop action fails with no loop count."""
data = {}
action = loop.LoopAction(data)
- action.WillRunAction(None, self._tab)
- self.assertRaises(AssertionError, action.RunAction, None, self._tab)
+ action.WillRunAction(self._tab)
+ self.assertRaises(AssertionError, action.RunAction, self._tab)
« no previous file with comments | « tools/telemetry/telemetry/page/actions/loop.py ('k') | tools/telemetry/telemetry/page/actions/media_action.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698