Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2764243002: Move files in wtf/ to platform/wtf/ (Part 9). (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, Mikhail, blink-reviews-wtf_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files in wtf/ to platform/wtf/ (Part 9). At this time, String related files are moved: HexNumber.h, MathExtras.h, RetainPtr.h, StringHasher.h, WTFThreadData.h (.cpp remaining), dtoa.{h,cpp}, dtoa/* In text/: ASCIIFastPath.h, AtomicString.{h,cpp}, AtomicStringCF.cpp, AtomicStringHash.h, AtomicStringTable.{h,cpp}, CString.{h,cpp}, CharacterNames.h, IntegerToStringConversion.h, StringBuffer.h, StringBuilder.{h,cpp}, StringConcatenate.{h,cpp}, StringHash.h, StringImpl.{h,cpp}, StringImplCF.cpp, StringImplMac.mm, StringMac.mm, StringOperators.h, StringStatics.{h,cpp}, StringToNumber.{h,cpp}, StringView.{h,cpp}, UTF8.{h,cpp}, WTFString.{h,cpp} BUG=691465 Review-Url: https://codereview.chromium.org/2764243002 Cr-Commit-Position: refs/heads/master@{#458980} Committed: https://chromium.googlesource.com/chromium/src/+/ee7e5087fdb40d8f9f7481ea628bfa98db6865d0

Patch Set 1 #

Patch Set 2 : Add a missing header in wtf/. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -16275 lines) Patch
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 4 chunks +62 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/HexNumber.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/MathExtras.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/RetainPtr.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/StringHasher.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/WTFThreadData.h View 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/COPYING View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/bignum.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/bignum.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/bignum-dtoa.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/cached-powers.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/cached-powers.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/diy-fp.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/diy-fp.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/double.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/double-conversion.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/fast-dtoa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/fast-dtoa.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/fixed-dtoa.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/strtod.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/strtod.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa/utils.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/ASCIIFastPath.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/AtomicString.h View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/AtomicString.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/AtomicStringCF.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/AtomicStringHash.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/AtomicStringTable.h View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/AtomicStringTable.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/CString.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/CString.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/CharacterNames.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/IntegerToStringConversion.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringBuffer.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringBuilder.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringBuilder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringConcatenate.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringConcatenate.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringHash.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringImpl.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp View 1 chunk +20 lines, -20 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringImplCF.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringImplMac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringMac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringOperators.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringStatics.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringStatics.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringToNumber.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringToNumber.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringView.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringView.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/UTF8.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/UTF8.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/WTFString.h View 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/WTFString.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 3 chunks +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/wtf/HexNumber.h View 1 chunk +7 lines, -109 lines 0 comments Download
M third_party/WebKit/Source/wtf/MathExtras.h View 1 chunk +7 lines, -433 lines 0 comments Download
M third_party/WebKit/Source/wtf/RetainPtr.h View 1 chunk +7 lines, -339 lines 0 comments Download
M third_party/WebKit/Source/wtf/StringHasher.h View 1 chunk +7 lines, -230 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTFThreadData.h View 1 chunk +7 lines, -87 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa.h View 1 1 chunk +7 lines, -83 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/COPYING View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/README View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/bignum.h View 1 chunk +7 lines, -144 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/bignum.cc View 1 chunk +0 lines, -768 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/bignum-dtoa.h View 1 chunk +7 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/bignum-dtoa.cc View 1 chunk +0 lines, -656 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/cached-powers.h View 1 chunk +7 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/cached-powers.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/diy-fp.h View 1 chunk +7 lines, -119 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/diy-fp.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/double.h View 1 chunk +7 lines, -247 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/double-conversion.h View 1 chunk +7 lines, -375 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/double-conversion.cc View 1 chunk +0 lines, -603 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/fast-dtoa.h View 1 chunk +7 lines, -86 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/fast-dtoa.cc View 1 chunk +0 lines, -739 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/fixed-dtoa.h View 1 chunk +7 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/fixed-dtoa.cc View 1 chunk +0 lines, -406 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/strtod.h View 1 chunk +7 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa/strtod.cc View 1 chunk +0 lines, -445 lines 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/utils.h View 1 chunk +7 lines, -302 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/ASCIIFastPath.h View 1 chunk +7 lines, -181 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.h View 1 chunk +7 lines, -310 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/AtomicString.cpp View 1 chunk +0 lines, -142 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/AtomicStringCF.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicStringHash.h View 1 chunk +7 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicStringTable.h View 1 chunk +5 lines, -60 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp View 1 chunk +0 lines, -221 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.h View 1 chunk +7 lines, -116 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/CString.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/CharacterNames.h View 1 chunk +7 lines, -222 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/IntegerToStringConversion.h View 1 chunk +7 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuffer.h View 1 chunk +7 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilder.h View 1 chunk +7 lines, -298 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringBuilder.cpp View 1 chunk +0 lines, -233 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.h View 1 chunk +7 lines, -227 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringConcatenate.cpp View 1 chunk +0 lines, -85 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringHash.h View 1 chunk +7 lines, -161 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 chunk +7 lines, -895 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 chunk +0 lines, -2244 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringImplCF.cpp View 1 chunk +0 lines, -164 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringImplMac.mm View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringMac.mm View 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringOperators.h View 1 chunk +7 lines, -200 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringStatics.h View 1 chunk +7 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringStatics.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringToNumber.h View 1 chunk +5 lines, -109 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringToNumber.cpp View 1 chunk +0 lines, -322 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringView.h View 1 chunk +5 lines, -268 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringView.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/UTF8.h View 1 chunk +7 lines, -90 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/UTF8.cpp View 1 chunk +0 lines, -466 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +7 lines, -604 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +0 lines, -832 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
Yuta Kitamura
PTAL?
3 years, 9 months ago (2017-03-22 09:16:32 UTC) #8
haraken
LGTM
3 years, 9 months ago (2017-03-22 09:25:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764243002/40001
3 years, 9 months ago (2017-03-22 10:51:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/63963)
3 years, 9 months ago (2017-03-22 11:17:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764243002/40001
3 years, 9 months ago (2017-03-23 01:09:07 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 02:25:15 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ee7e5087fdb40d8f9f7481ea628b...

Powered by Google App Engine
This is Rietveld 408576698