Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2764283002: Move files in wtf/ to platform/wtf/ (Part 10). (Closed)

Created:
3 years, 9 months ago by Yuta Kitamura
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, abarth-chromium, blink-reviews, kinuko+watch, blink-reviews-wtf_chromium.org, jshin+watch_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move files in wtf/ to platform/wtf/ (Part 10). This patch moves all the remaining files in wtf/text/: In text/: Base64.{h,cpp}, Collator.h, icu/CollatorICU.cpp, ParsingUtilities.h, StringUTF8Adaptor.h, TextCodecASCIIFastPath.h, TextCodec.{h,cpp}, TextCodecICU.{h,cpp}, TextCodecLatin1.{h,cpp}, TextCodecReplacement.{h,cpp}, TextCodecUserDefined.{h,cpp}, TextCodecUTF{8,16}.{h,cpp}, TextEncoding.{h,cpp}, TextEncodingRegistry.{h,cpp}, TextPosition.{h,cpp} Also, wtf/text/OWNERS is moved to platform/wtf/text/ at this time. BUG=691465 Review-Url: https://codereview.chromium.org/2764283002 Cr-Commit-Position: refs/heads/master@{#459033} Committed: https://chromium.googlesource.com/chromium/src/+/12c22a184ff8ee639fab5a44d6924a0bb47a4df3

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -4329 lines) Patch
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 2 chunks +27 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/Base64.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/Base64.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/Collator.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/ParsingUtilities.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringUTF8Adaptor.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodec.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodec.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecASCIIFastPath.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecICU.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecICU.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecLatin1.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecLatin1.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecReplacement.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecReplacement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUserDefined.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUserDefined.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextEncoding.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextEncoding.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextEncodingRegistry.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextEncodingRegistry.cpp View 1 chunk +18 lines, -18 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextPosition.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextPosition.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/icu/CollatorICU.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 2 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/Base64.h View 1 chunk +7 lines, -127 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/Base64.cpp View 1 chunk +0 lines, -272 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/Collator.h View 1 chunk +7 lines, -76 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/ParsingUtilities.h View 1 chunk +7 lines, -96 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringUTF8Adaptor.h View 1 chunk +7 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodec.h View 1 chunk +7 lines, -119 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodec.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecASCIIFastPath.h View 1 chunk +7 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecICU.h View 1 chunk +7 lines, -105 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecICU.cpp View 1 chunk +0 lines, -711 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecLatin1.h View 1 chunk +7 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecLatin1.cpp View 1 chunk +0 lines, -293 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecReplacement.h View 1 chunk +5 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecReplacement.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF16.h View 1 chunk +7 lines, -56 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp View 1 chunk +0 lines, -212 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF8.h View 1 chunk +7 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp View 1 chunk +0 lines, -498 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUserDefined.h View 1 chunk +7 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecUserDefined.cpp View 1 chunk +0 lines, -146 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextEncoding.h View 1 chunk +7 lines, -97 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextEncoding.cpp View 1 chunk +0 lines, -194 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextEncodingRegistry.h View 1 chunk +7 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp View 1 chunk +0 lines, -316 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextPosition.h View 1 chunk +7 lines, -118 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextPosition.cpp View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/icu/CollatorICU.cpp View 1 chunk +0 lines, -142 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
Yuta Kitamura
PTAL?
3 years, 9 months ago (2017-03-22 10:53:21 UTC) #8
haraken
LGTM
3 years, 9 months ago (2017-03-22 11:04:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764283002/40001
3 years, 9 months ago (2017-03-23 02:53:44 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/304251)
3 years, 9 months ago (2017-03-23 03:09:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2764283002/40001
3 years, 9 months ago (2017-03-23 08:21:58 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 09:51:55 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/12c22a184ff8ee639fab5a44d692...

Powered by Google App Engine
This is Rietveld 408576698