Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2738953002: Rename WebParsedFeaturePolicyHeader to WebParsedFeaturePolicy (Closed)

Created:
3 years, 9 months ago by lunalu1
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, iclelland, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial Implementation of Iframe Attribute for Feature Policy (Part 3.b) WebParsedFeaturePolicyHeader is renamed because this DS will be shared between both header policy and container policy and in the future meta tag policy and container header policy. BUG=682256 Review-Url: https://codereview.chromium.org/2738953002 Cr-Commit-Position: refs/heads/master@{#456489} Committed: https://chromium.googlesource.com/chromium/src/+/0baeb8b4f2a11f29104b2c989a584242acd139f3

Patch Set 1 : Initial Impl #

Patch Set 2 : ParsedFeaturePolicyHeader => ParsedFeaturePolicy (content version) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M content/child/blink_platform_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/feature_policy/feature_policy_platform.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/feature_policy/feature_policy_platform.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SecurityContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SecurityContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebFeaturePolicy.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrame.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 41 (27 generated)
lunalu1
Hi Raymes, could you PTAL? Thanks
3 years, 9 months ago (2017-03-08 22:17:57 UTC) #6
raymes
lgtm, thanks! In the CL description, you might want to move the description for this ...
3 years, 9 months ago (2017-03-09 01:00:19 UTC) #14
lunalu1
Hi esprehn@, PTAL at this CL and give me an owner approval. Thanks
3 years, 9 months ago (2017-03-09 01:14:52 UTC) #17
esprehn
All this plumbing is doing is sending legacy IPCs: https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?q=didSetFeaturePolicyHeader+package:%5Echromium$&l=3196 can we onion soup it ...
3 years, 9 months ago (2017-03-09 07:13:50 UTC) #18
lunalu1
On 2017/03/09 07:13:50, esprehn wrote: > All this plumbing is doing is sending legacy IPCs: ...
3 years, 9 months ago (2017-03-09 20:24:25 UTC) #19
raymes
On 2017/03/09 07:13:50, esprehn wrote: > All this plumbing is doing is sending legacy IPCs: ...
3 years, 9 months ago (2017-03-12 23:55:12 UTC) #21
esprehn
On 2017/03/12 at 23:55:12, raymes wrote: > On 2017/03/09 07:13:50, esprehn wrote: > > All ...
3 years, 9 months ago (2017-03-13 00:45:30 UTC) #22
esprehn
I discussed with raymes about what's going on here. I think we want to move ...
3 years, 9 months ago (2017-03-13 03:22:17 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738953002/20001
3 years, 9 months ago (2017-03-13 14:24:21 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738953002/20001
3 years, 9 months ago (2017-03-13 14:25:10 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/382009)
3 years, 9 months ago (2017-03-13 16:53:41 UTC) #34
alexmos
On 2017/03/12 23:55:12, raymes wrote: > On 2017/03/09 07:13:50, esprehn wrote: > > All this ...
3 years, 9 months ago (2017-03-13 17:45:23 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738953002/40001
3 years, 9 months ago (2017-03-13 20:35:36 UTC) #38
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 21:25:35 UTC) #41
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0baeb8b4f2a11f29104b2c989a58...

Powered by Google App Engine
This is Rietveld 408576698