Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 26880010: gfx: Add FrameTime and DisplayTime classes (Closed)

Created:
7 years, 2 months ago by brianderson
Modified:
5 years, 8 months ago
Reviewers:
mithro-old
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@checkHighResNow4
Visibility:
Public.

Description

gfx: Add FrameTime and DisplayTime classes This patch replaces base::TimeTicks with gfx::FrameTime for everything related to animations, scheduling, and display times. In a subsequent patch, DisplayTime will also be used to indicate parts of code that need a timestamp that should be aligned with the display's refresh phase. FrameTime and DisplayTime both have methods that start with "Unsafe", which will mark areas of code that are potentially using an incorrect timestamp. Further followups should remove calls to the Unsafe methods so we can remove them. BUG=311570

Patch Set 1 #

Total comments: 1

Patch Set 2 : WIP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -346 lines) Patch
M ash/wm/window_animations.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M cc/animation/scrollbar_animation_controller.h View 1 2 chunks +9 lines, -6 lines 0 comments Download
M cc/animation/scrollbar_animation_controller_linear_fade.h View 1 2 chunks +10 lines, -8 lines 0 comments Download
M cc/animation/scrollbar_animation_controller_linear_fade.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download
M cc/animation/scrollbar_animation_controller_linear_fade_unittest.cc View 1 7 chunks +8 lines, -7 lines 0 comments Download
M cc/animation/scrollbar_animation_controller_thinning.h View 1 3 chunks +10 lines, -8 lines 0 comments Download
M cc/animation/scrollbar_animation_controller_thinning.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M cc/animation/scrollbar_animation_controller_thinning_unittest.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M cc/debug/frame_rate_counter.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M cc/debug/frame_rate_counter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/input/input_handler.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/input/top_controls_manager.h View 1 3 chunks +3 lines, -6 lines 0 comments Download
M cc/input/top_controls_manager.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/begin_frame_args.h View 1 3 chunks +7 lines, -6 lines 0 comments Download
M cc/output/begin_frame_args.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M cc/output/output_surface.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/output/output_surface.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/resource_update_controller.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/resources/resource_update_controller.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M cc/scheduler/frame_rate_controller.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scheduler/frame_rate_controller.cc View 1 3 chunks +15 lines, -10 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 3 chunks +7 lines, -6 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 5 chunks +14 lines, -11 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 1 chunk +8 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 8 chunks +13 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 14 chunks +20 lines, -20 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 11 chunks +11 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/loading_animation.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/loading_animation.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor_observer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animation_element.h View 1 4 chunks +9 lines, -8 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M ui/compositor/layer_animation_element_unittest.cc View 1 11 chunks +15 lines, -14 lines 0 comments Download
M ui/compositor/layer_animation_sequence.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M ui/compositor/layer_animation_sequence_unittest.cc View 1 10 chunks +13 lines, -12 lines 0 comments Download
M ui/compositor/layer_animator.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M ui/gfx/animation/animation.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/animation/animation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/animation/animation_container.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/animation/animation_container.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M ui/gfx/animation/animation_container_element.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/animation/linear_animation.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/animation/linear_animation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/animation/multi_animation.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/animation/multi_animation.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/animation/multi_animation_unittest.cc View 1 4 chunks +11 lines, -11 lines 0 comments Download
M ui/gfx/animation/slide_animation_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/animation/throb_animation.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/animation/throb_animation.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/frame_time.h View 1 1 chunk +127 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brianderson
https://codereview.chromium.org/26880010/diff/1/ui/gfx/frame_time.h File ui/gfx/frame_time.h (right): https://codereview.chromium.org/26880010/diff/1/ui/gfx/frame_time.h#newcode101 ui/gfx/frame_time.h:101: // If animations are using anything other than a ...
7 years, 2 months ago (2013-10-17 18:42:20 UTC) #1
mithro-old
6 years, 9 months ago (2014-03-05 04:00:44 UTC) #2
mithro-old
You can close this issue now.
6 years ago (2014-12-19 06:17:20 UTC) #3
mithro-old
5 years, 8 months ago (2015-04-02 04:35:12 UTC) #4
Hey Brian,

Can you close this CL?

Tim

Powered by Google App Engine
This is Rietveld 408576698