Turn on clang format as an upload step for all the repo.

Turn on clang format as an upload step for all the repo.

Discussion at https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2680413002
Cr-Commit-Position: refs/heads/master@{#449148}
Committed: https://chromium.googlesource.com/chromium/src/+/93a6ee79f37afd04984937c279c3b6b87864e303

[jam, 2017-02-08 22:37:16]

Description was changed from

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
==========

to

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jam, 2017-02-08 22:37:17]

Description was changed from

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[jam, 2017-02-08 22:37:17]

Description was changed from

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jam, 2017-02-08 22:37:18]

Description was changed from

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jam, 2017-02-08 22:38:12]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 22:38:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-08 23:07:33]

jam@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-08 23:18:21]

On 2017/02/08 23:07:34, jam wrote:

LGTM

[commit-bot: I haz the power, 2017-02-08 23:41:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:41:29]

Dry run: This issue passed the CQ dry run.

[jam, 2017-02-08 23:50:58]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:51:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:59:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486597858781080, "parent_rev":
"64a29a636fccf8d7e1f09d6ee445666622561ed0", "commit_rev":
"93a6ee79f37afd04984937c279c3b6b87864e303"}

[commit-bot: I haz the power, 2017-02-09 00:00:26]

Description was changed from

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Turn on clang format as an upload step for all the repo.

Discussion at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/7Zm1Z49TV7U
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2680413002
Cr-Commit-Position: refs/heads/master@{#449148}
Committed:
https://chromium.googlesource.com/chromium/src/+/93a6ee79f37afd04984937c279c3...
==========

[commit-bot: I haz the power, 2017-02-09 00:00:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/93a6ee79f37afd04984937c279c3...

[Dan Beam, 2017-02-10 19:10:06]

https://codereview.chromium.org/2680413002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2680413002/diff/1/PRESUBMIT.py#newcode2375
PRESUBMIT.py:2375: input_api.canned_checks.CheckPatchFormatted(input_api,
output_api))
fyi: this certainly appears to be running formatting checks on commit as well

[Dan Beam, 2017-02-10 20:11:39]

https://codereview.chromium.org/2680413002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/2680413002/diff/1/PRESUBMIT.py#newcode2375
PRESUBMIT.py:2375: input_api.canned_checks.CheckPatchFormatted(input_api,
output_api))
On 2017/02/10 19:10:06, Dan Beam wrote:
> fyi: this certainly appears to be running formatting checks on commit as well

follow up: as dcheng@ mentioned on chromium-dev@: because this check returns
PresubmitPromptWarnings (rather than PresubmitErrors), this will not block a CQ

[Dan Beam, 2017-02-10 22:54:13]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-02-10 22:54:13]

https://codereview.chromium.org/2680413002/diff/1/ui/webui/resources/PRESUBMI...
File ui/webui/resources/PRESUBMIT.py (left):

https://codereview.chromium.org/2680413002/diff/1/ui/webui/resources/PRESUBMI...
ui/webui/resources/PRESUBMIT.py:79: check_js=True)
why did you remove this?  note the check_js=True

[jam, 2017-02-10 22:59:39]

https://codereview.chromium.org/2680413002/diff/1/ui/webui/resources/PRESUBMI...
File ui/webui/resources/PRESUBMIT.py (left):

https://codereview.chromium.org/2680413002/diff/1/ui/webui/resources/PRESUBMI...
ui/webui/resources/PRESUBMIT.py:79: check_js=True)
On 2017/02/10 22:54:13, Dan Beam wrote:
> why did you remove this?  note the check_js=True

oops, that was by accident. I'll restore this and the other callsite, thanks for
pointing it out.