extensions/browser/PRESUBMIT.py - Issue 2680413002: Turn on clang format as an upload step for all the repo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/PRESUBMIT.py

Issue 2680413002: Turn on clang format as an upload step for all the repo. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Chromium presubmit script for src/extensions/browser.	5 """Chromium presubmit script for src/extensions/browser.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details on the presubmit API built into depot_tools.	8 for more details on the presubmit API built into depot_tools.

9 """	9 """

10	10

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 return presubmit_bad_message_reasons.PrecheckBadMessage(input_api,	47 return presubmit_bad_message_reasons.PrecheckBadMessage(input_api,

48 output_api, histogram_name)	48 output_api, histogram_name)

49 except:	49 except:

50 return [output_api.PresubmitError('Could not verify histogram!')]	50 return [output_api.PresubmitError('Could not verify histogram!')]

51 finally:	51 finally:

52 sys.path = original_sys_path	52 sys.path = original_sys_path

53	53

54 def CheckChangeOnUpload(input_api, output_api):	54 def CheckChangeOnUpload(input_api, output_api):

55 results = []	55 results = []

56 results += _RunHistogramValueCheckers(input_api, output_api)	56 results += _RunHistogramValueCheckers(input_api, output_api)

57 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

58 results += _RunHistogramChecks(input_api, output_api,	57 results += _RunHistogramChecks(input_api, output_api,

59 "BadMessageReasonExtensions")	58 "BadMessageReasonExtensions")

60 return results	59 return results

OLD	NEW

« PRESUBMIT.py ('K') | « device/PRESUBMIT.py ('k') | extensions/common/PRESUBMIT.py » ('j') | ui/webui/resources/PRESUBMIT.py » ('J')