chrome/common/extensions/PRESUBMIT.py - Issue 2680413002: Turn on clang format as an upload step for all the repo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/PRESUBMIT.py

Issue 2680413002: Turn on clang format as an upload step for all the repo. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/PRESUBMIT.py

diff --git a/chrome/common/extensions/PRESUBMIT.py b/chrome/common/extensions/PRESUBMIT.py

index bcfba68e3f109b9859cfaaa594bf67bc11477505..1b0d113938c35b76893ae385836ff75817c24dc7 100644

--- a/chrome/common/extensions/PRESUBMIT.py

+++ b/chrome/common/extensions/PRESUBMIT.py

@@ -162,7 +162,6 @@ def _CheckChange(input_api, output_api):

def CheckChangeOnUpload(input_api, output_api):

results = []

- results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

results += _CheckChange(input_api, output_api)

return results