OLD | NEW |
---|---|
1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 import re | 5 import re |
6 | 6 |
7 | 7 |
8 def PostUploadHook(cl, change, output_api): | 8 def PostUploadHook(cl, change, output_api): |
9 rietveld_obj = cl.RpcServer() | 9 rietveld_obj = cl.RpcServer() |
10 description = rietveld_obj.get_description(cl.issue) | 10 description = rietveld_obj.get_description(cl.issue) |
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
68 return [output_api.PresubmitError("\n".join(errors) + """ | 68 return [output_api.PresubmitError("\n".join(errors) + """ |
69 | 69 |
70 Don't embed translations directly in shared UI code. Instead, inject your | 70 Don't embed translations directly in shared UI code. Instead, inject your |
71 translation from the place using the shared code. For an example: see | 71 translation from the place using the shared code. For an example: see |
72 <cr-dialog>#closeText (http://bit.ly/2eLEsqh).""")] | 72 <cr-dialog>#closeText (http://bit.ly/2eLEsqh).""")] |
73 | 73 |
74 | 74 |
75 def _CommonChecks(input_api, output_api): | 75 def _CommonChecks(input_api, output_api): |
76 results = [] | 76 results = [] |
77 results += _CheckForTranslations(input_api, output_api) | 77 results += _CheckForTranslations(input_api, output_api) |
78 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api, | |
79 check_js=True) | |
Dan Beam
2017/02/10 22:54:13
why did you remove this? note the check_js=True
jam
2017/02/10 22:59:39
oops, that was by accident. I'll restore this and
| |
80 return results | 78 return results |
OLD | NEW |