chrome/common/extensions/PRESUBMIT.py - Issue 2680413002: Turn on clang format as an upload step for all the repo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/PRESUBMIT.py

Issue 2680413002: Turn on clang format as an upload step for all the repo. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« PRESUBMIT.py ('K') | « chrome/browser/ui/views/ash/PRESUBMIT.py ('k') | chrome/renderer/extensions/PRESUBMIT.py » ('j') | ui/webui/resources/PRESUBMIT.py » ('J')

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for changes affecting extensions.	5 """Presubmit script for changes affecting extensions.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into depot_tools.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10 import fnmatch	10 import fnmatch

(...skipping 144 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
155	155

156 # TODO(kalman): Re-enable this check, or decide to delete it forever. Now	156 # TODO(kalman): Re-enable this check, or decide to delete it forever. Now

157 # that we have multiple directories it no longer works.	157 # that we have multiple directories it no longer works.

158 # See http://crbug.com/297178.	158 # See http://crbug.com/297178.

159 #_CheckLinks(input_api, output_api, results)	159 #_CheckLinks(input_api, output_api, results)

160	160

161 return results	161 return results

162	162

163 def CheckChangeOnUpload(input_api, output_api):	163 def CheckChangeOnUpload(input_api, output_api):

164 results = []	164 results = []

165 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

166 results += _CheckChange(input_api, output_api)	165 results += _CheckChange(input_api, output_api)

167 return results	166 return results

168	167

169 def CheckChangeOnCommit(input_api, output_api):	168 def CheckChangeOnCommit(input_api, output_api):

170 return _CheckChange(input_api, output_api)	169 return _CheckChange(input_api, output_api)

OLD	NEW