Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: PRESUBMIT.py

Issue 2680413002: Turn on clang format as an upload step for all the repo. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | apps/PRESUBMIT.py » ('j') | ui/webui/resources/PRESUBMIT.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 686ae511773be4835973f9e2dac4ab7d9776bd2b..34fb5e6c23e56842094019b4c549c96e61d23cc7 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -2315,6 +2315,8 @@ def CheckChangeOnUpload(input_api, output_api):
results.extend(_CommonChecks(input_api, output_api))
results.extend(_CheckValidHostsInDEPS(input_api, output_api))
results.extend(
+ input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
+ results.extend(
input_api.canned_checks.CheckGNFormatted(input_api, output_api))
results.extend(_CheckUmaHistogramChanges(input_api, output_api))
results.extend(_AndroidSpecificOnUploadChecks(input_api, output_api))
@@ -2369,6 +2371,8 @@ def CheckChangeOnCommit(input_api, output_api):
output_api,
json_url='http://chromium-status.appspot.com/current?format=json'))
+ results.extend(
+ input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
Dan Beam 2017/02/10 19:10:06 fyi: this certainly appears to be running formatti
Dan Beam 2017/02/10 20:11:39 follow up: as dcheng@ mentioned on chromium-dev@:
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasDescription(
« no previous file with comments | « no previous file | apps/PRESUBMIT.py » ('j') | ui/webui/resources/PRESUBMIT.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698