Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 2297 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2308 'Please make sure there are no privacy sensitive bits of data in SYSLOG' | 2308 'Please make sure there are no privacy sensitive bits of data in SYSLOG' |
| 2309 ' calls.\nFiles to check:\n', items=syslog_files)] | 2309 ' calls.\nFiles to check:\n', items=syslog_files)] |
| 2310 return [] | 2310 return [] |
| 2311 | 2311 |
| 2312 | 2312 |
| 2313 def CheckChangeOnUpload(input_api, output_api): | 2313 def CheckChangeOnUpload(input_api, output_api): |
| 2314 results = [] | 2314 results = [] |
| 2315 results.extend(_CommonChecks(input_api, output_api)) | 2315 results.extend(_CommonChecks(input_api, output_api)) |
| 2316 results.extend(_CheckValidHostsInDEPS(input_api, output_api)) | 2316 results.extend(_CheckValidHostsInDEPS(input_api, output_api)) |
| 2317 results.extend( | 2317 results.extend( |
| 2318 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) | |
| 2319 results.extend( | |
| 2318 input_api.canned_checks.CheckGNFormatted(input_api, output_api)) | 2320 input_api.canned_checks.CheckGNFormatted(input_api, output_api)) |
| 2319 results.extend(_CheckUmaHistogramChanges(input_api, output_api)) | 2321 results.extend(_CheckUmaHistogramChanges(input_api, output_api)) |
| 2320 results.extend(_AndroidSpecificOnUploadChecks(input_api, output_api)) | 2322 results.extend(_AndroidSpecificOnUploadChecks(input_api, output_api)) |
| 2321 results.extend(_CheckSyslogUseWarning(input_api, output_api)) | 2323 results.extend(_CheckSyslogUseWarning(input_api, output_api)) |
| 2322 results.extend(_CheckGoogleSupportAnswerUrl(input_api, output_api)) | 2324 results.extend(_CheckGoogleSupportAnswerUrl(input_api, output_api)) |
| 2323 return results | 2325 return results |
| 2324 | 2326 |
| 2325 | 2327 |
| 2326 def GetTryServerMasterForBot(bot): | 2328 def GetTryServerMasterForBot(bot): |
| 2327 """Returns the Try Server master for the given bot. | 2329 """Returns the Try Server master for the given bot. |
| (...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2362 | 2364 |
| 2363 def CheckChangeOnCommit(input_api, output_api): | 2365 def CheckChangeOnCommit(input_api, output_api): |
| 2364 results = [] | 2366 results = [] |
| 2365 results.extend(_CommonChecks(input_api, output_api)) | 2367 results.extend(_CommonChecks(input_api, output_api)) |
| 2366 # Make sure the tree is 'open'. | 2368 # Make sure the tree is 'open'. |
| 2367 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 2369 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 2368 input_api, | 2370 input_api, |
| 2369 output_api, | 2371 output_api, |
| 2370 json_url='http://chromium-status.appspot.com/current?format=json')) | 2372 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2371 | 2373 |
| 2374 results.extend( | |
| 2375 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) | |
|
Dan Beam
2017/02/10 19:10:06
fyi: this certainly appears to be running formatti
Dan Beam
2017/02/10 20:11:39
follow up: as dcheng@ mentioned on chromium-dev@:
| |
| 2372 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2376 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2373 input_api, output_api)) | 2377 input_api, output_api)) |
| 2374 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2378 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2375 input_api, output_api)) | 2379 input_api, output_api)) |
| 2376 return results | 2380 return results |
| OLD | NEW |