extensions/browser/PRESUBMIT.py - Issue 2680413002: Turn on clang format as an upload step for all the repo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/PRESUBMIT.py

Issue 2680413002: Turn on clang format as an upload step for all the repo. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/PRESUBMIT.py

diff --git a/extensions/browser/PRESUBMIT.py b/extensions/browser/PRESUBMIT.py

index 5bd5fad6735c3491757cdc26a4085ee019d2d2a3..1a82b42c9e39b6259dc07c7a04969acb755976e3 100644

--- a/extensions/browser/PRESUBMIT.py

+++ b/extensions/browser/PRESUBMIT.py

@@ -54,7 +54,6 @@ def _RunHistogramChecks(input_api, output_api, histogram_name):

def CheckChangeOnUpload(input_api, output_api):

results = []

results += _RunHistogramValueCheckers(input_api, output_api)

- results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

results += _RunHistogramChecks(input_api, output_api,

"BadMessageReasonExtensions")

return results