Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: third_party/WebKit/PRESUBMIT.py

Issue 2680413002: Turn on clang format as an upload step for all the repo. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Blink. 5 """Top-level presubmit script for Blink.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 93
94 def _CommonChecks(input_api, output_api): 94 def _CommonChecks(input_api, output_api):
95 """Checks common to both upload and commit.""" 95 """Checks common to both upload and commit."""
96 # We should figure out what license checks we actually want to use. 96 # We should figure out what license checks we actually want to use.
97 license_header = r'.*' 97 license_header = r'.*'
98 98
99 results = [] 99 results = []
100 results.extend(input_api.canned_checks.PanProjectChecks( 100 results.extend(input_api.canned_checks.PanProjectChecks(
101 input_api, output_api, excluded_paths=_EXCLUDED_PATHS, 101 input_api, output_api, excluded_paths=_EXCLUDED_PATHS,
102 maxlen=800, license_header=license_header)) 102 maxlen=800, license_header=license_header))
103 results.extend(input_api.canned_checks.CheckPatchFormatted(input_api, output _api))
104 results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api)) 103 results.extend(_CheckForNonBlinkVariantMojomIncludes(input_api, output_api))
105 results.extend(_CheckForVersionControlConflicts(input_api, output_api)) 104 results.extend(_CheckForVersionControlConflicts(input_api, output_api))
106 results.extend(_CheckPatchFiles(input_api, output_api)) 105 results.extend(_CheckPatchFiles(input_api, output_api))
107 results.extend(_CheckTestExpectations(input_api, output_api)) 106 results.extend(_CheckTestExpectations(input_api, output_api))
108 results.extend(_CheckChromiumPlatformMacros(input_api, output_api)) 107 results.extend(_CheckChromiumPlatformMacros(input_api, output_api))
109 results.extend(_CheckWatchlist(input_api, output_api)) 108 results.extend(_CheckWatchlist(input_api, output_api))
110 results.extend(_CheckFilePermissions(input_api, output_api)) 109 results.extend(_CheckFilePermissions(input_api, output_api))
111 return results 110 return results
112 111
113 112
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 new_description = description 377 new_description = description
379 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots) 378 new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots)
380 results.append(output_api.PresubmitNotifyResult( 379 results.append(output_api.PresubmitNotifyResult(
381 'Automatically added slimming-paint-v2 tests to run on CQ due to ' 380 'Automatically added slimming-paint-v2 tests to run on CQ due to '
382 'changes in paint or compositing directories.')) 381 'changes in paint or compositing directories.'))
383 382
384 if new_description != description: 383 if new_description != description:
385 rietveld_obj.update_description(issue, new_description) 384 rietveld_obj.update_description(issue, new_description)
386 385
387 return results 386 return results
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698