Remove uses of VisitDOMWrapper

Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

This patch leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty implementations which are cleaned up in a separate CL.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2671553003
Cr-Commit-Position: refs/heads/master@{#448124}
Committed: https://chromium.googlesource.com/chromium/src/+/557d8dae7b89fd745eddb5d690e048795db7f448

[Michael Lippautz, 2017-02-01 23:48:47]

Description was changed from

==========
Remove uses of VisitDOMWrapper

BUG=
==========

to

==========
Remove uses of VisitDOMWrapper

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-01 23:57:05]

Patchset #1 (id:1) has been deleted

[Michael Lippautz, 2017-02-02 16:12:10]

Patchset #1 (id:20001) has been deleted

[Michael Lippautz, 2017-02-02 19:40:49]

Patchset #1 (id:40001) has been deleted

[Michael Lippautz, 2017-02-02 19:53:31]

Description was changed from

==========
Remove uses of VisitDOMWrapper

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove uses of VisitDOMWrapper

Remove VisitDOMWrapper and VisitDOMWrapperCustom

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-02 19:54:29]

Description was changed from

==========
Remove uses of VisitDOMWrapper

Remove VisitDOMWrapper and VisitDOMWrapperCustom

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

Leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty
implementations.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-02 19:54:29]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org, jochen@chromium.org

[Michael Lippautz, 2017-02-02 19:54:54]

ptal and lmk if we should also remove SetWrapperReferenceFrom and
SetWrapperReferenceTo in this CL.

[Michael Lippautz, 2017-02-02 19:55:21]

On 2017/02/02 19:54:54, Michael Lippautz (slow travel) wrote:
> ptal and lmk if we should also remove SetWrapperReferenceFrom and
> SetWrapperReferenceTo in this CL.

Forgot: Will update bindings tests expectations before committing.

[Michael Lippautz, 2017-02-02 19:55:59]

Description was changed from

==========
Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

Leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty
implementations.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

Leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty
implementations.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-02 20:00:14]

Patchset #2 (id:80001) has been deleted

[haraken, 2017-02-02 20:54:09]

LGTM!!

[Michael Lippautz, 2017-02-02 23:45:06]

Description was changed from

==========
Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

Leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty
implementations.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

This patch leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty
implementations which are cleaned up in a separate CL.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Michael Lippautz, 2017-02-03 01:22:48]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 01:23:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 02:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 02:41:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Michael Lippautz, 2017-02-03 03:06:30]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2017-02-03 03:06:31]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2671553003/#ps120001
(title: "run-bindings-tests --reset-results")

[commit-bot: I haz the power, 2017-02-03 03:07:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 03:23:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 03:23:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jochen (gone - plz use gerrit), 2017-02-03 06:30:27]

lgtm once it actually works :)

[Michael Lippautz, 2017-02-03 22:28:03]

haraken/jochen: please take another look

Custom=VisitDOMWrapper implied DependentLifetime, so I am adding not
DependentLifetime explicitly to those objects as they will otherwise be
collected.

[Michael Lippautz, 2017-02-03 22:28:40]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 22:29:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-02-03 22:32:11]

On 2017/02/03 22:28:03, Michael Lippautz (slow travel) wrote:
> haraken/jochen: please take another look
> 
> Custom=VisitDOMWrapper implied DependentLifetime, so I am adding not
> DependentLifetime explicitly to those objects as they will otherwise be
> collected.

s/not/now/

[commit-bot: I haz the power, 2017-02-04 00:09:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:09:59]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2017-02-04 00:10:39]

On 2017/02/03 22:32:11, Michael Lippautz (slow travel) wrote:
> On 2017/02/03 22:28:03, Michael Lippautz (slow travel) wrote:
> > haraken/jochen: please take another look
> > 
> > Custom=VisitDOMWrapper implied DependentLifetime, so I am adding not
> > DependentLifetime explicitly to those objects as they will otherwise be
> > collected.
> 
> s/not/now/

Talked to Jochen offline, and he thinks this should be fine. Landing now...

[Michael Lippautz, 2017-02-04 00:10:50]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2017-02-04 00:10:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2671553003/#ps140001
(title: "Add DependentLifetime when removing Custom=VisitDOMWrapper")

[commit-bot: I haz the power, 2017-02-04 00:11:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:44:15]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1486167050748890,
"parent_rev": "e37073cf5dc5e7e0a770e967af8571d455cacfe4", "commit_rev":
"557d8dae7b89fd745eddb5d690e048795db7f448"}

[commit-bot: I haz the power, 2017-02-04 00:44:48]

Description was changed from

==========
Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

This patch leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty
implementations which are cleaned up in a separate CL.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove uses of VisitDOMWrapper

- Remove VisitDOMWrapper and VisitDOMWrapperCustom
- Remove IDL attributes Custom=VisitDOMWrapper

This patch leaves behind SetWrapperReferenceFrom and SetReferenceTo with empty
implementations which are cleaned up in a separate CL.

BUG=chromium:682688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2671553003
Cr-Commit-Position: refs/heads/master@{#448124}
Committed:
https://chromium.googlesource.com/chromium/src/+/557d8dae7b89fd745eddb5d690e0...
==========

[commit-bot: I haz the power, 2017-02-04 00:44:50]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/557d8dae7b89fd745eddb5d690e0...

[haraken, 2017-02-04 09:20:01]

On 2017/02/04 00:44:50, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:140001) as
>
https://chromium.googlesource.com/chromium/src/+/557d8dae7b89fd745eddb5d690e0...

LGTM