third_party/WebKit/Source/bindings/core/v8/custom/V8PromiseRejectionEventCustom.cpp - Issue 2671553003: Remove uses of VisitDOMWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PromiseRejectionEventCustom.cpp

Issue 2671553003: Remove uses of VisitDOMWrapper (Closed)

Patch Set: Add DependentLifetime when removing Custom=VisitDOMWrapper Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/custom/V8MediaSessionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PromiseRejectionEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PromiseRejectionEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PromiseRejectionEventCustom.cpp

index ba4967b28f0a7d5f2c60a5a62c2bc624b25195a3..ebc9dd0ff3a7dff4f5cadc27358bf0e2d3ed96a6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PromiseRejectionEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PromiseRejectionEventCustom.cpp

@@ -25,13 +25,4 @@ void V8PromiseRejectionEvent::promiseAttributeGetterCustom(

v8SetReturnValue(info, promise.v8Value());

}

-void V8PromiseRejectionEvent::visitDOMWrapperCustom(

- v8::Isolate* isolate,

- ScriptWrappable* scriptWrappable,

- const v8::Persistent<v8::Object>& wrapper) {

- PromiseRejectionEvent* event =

- scriptWrappable->toImpl<PromiseRejectionEvent>();

- event->setWrapperReference(isolate, wrapper);

} // namespace blink